Bug 1120622 - Define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION for all gcc versions now that we don't support 4.4 any more; r=froydnj
☠☠ backed out by 42cd4e7cbd14 ☠ ☠
authorEhsan Akhgari <ehsan@mozilla.com>
Mon, 12 Jan 2015 15:41:29 -0500
changeset 223433 73fcb9fa303df13dbd99891648e54aa677a259e5
parent 223432 e891f69a7edcba068cd40d71de30001e9e3a86b6
child 223434 76ca49362a26525c783abe1e9598f277e6a9e9a6
push id28095
push usercbook@mozilla.com
push dateTue, 13 Jan 2015 13:24:48 +0000
treeherdermozilla-central@a5700bec72e1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1120622
milestone38.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1120622 - Define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION for all gcc versions now that we don't support 4.4 any more; r=froydnj
mfbt/Assertions.h
--- a/mfbt/Assertions.h
+++ b/mfbt/Assertions.h
@@ -297,23 +297,18 @@ MOZ_ReportCrash(const char* aStr, const 
  */
 
 /*
  * Implement MOZ_VALIDATE_ASSERT_CONDITION_TYPE, which is used to guard against
  * accidentally passing something unintended in lieu of an assertion condition.
  */
 
 #ifdef __cplusplus
-#  if defined(__clang__)
+#  if defined(__clang__) || defined(__GNUC__)
 #    define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION
-#  elif defined(__GNUC__)
-//   B2G GCC 4.4 has insufficient decltype support.
-#    if MOZ_GCC_VERSION_AT_LEAST(4, 5, 0)
-#      define MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION
-#    endif
 #  elif defined(_MSC_VER)
 //   Disabled for now because of insufficient decltype support. Bug 1004028.
 #  endif
 #endif
 
 #ifdef MOZ_SUPPORT_ASSERT_CONDITION_TYPE_VALIDATION
 #  include "mozilla/TypeTraits.h"
 namespace mozilla {