Bug 1451685 - Pass element as the first argument to DOMLocalization.setAttributes in updateWeavePrefs. r=Gijs
authorZibi Braniecki <zbraniecki@mozilla.com>
Thu, 05 Apr 2018 12:56:00 +0200
changeset 411886 7382668f782af59b322e0b48bb884344e065836d
parent 411885 7c0093bf53b59d60385ff418e174b733f86cdd16
child 411887 edaa920ba38b2509cdbbcab820cbf7c5712165bd
push id33773
push usernerli@mozilla.com
push dateThu, 05 Apr 2018 15:14:44 +0000
treeherdermozilla-central@e5b89dcca72e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1451685
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1451685 - Pass element as the first argument to DOMLocalization.setAttributes in updateWeavePrefs. r=Gijs MozReview-Commit-ID: 9okSh01qykH
browser/components/preferences/in-content/sync.js
--- a/browser/components/preferences/in-content/sync.js
+++ b/browser/components/preferences/in-content/sync.js
@@ -284,17 +284,17 @@ var gSyncPane = {
     } else {
       // We must be golden (or in an error state we expect to magically
       // resolve itself)
       fxaLoginStatus.selectedIndex = FXA_LOGIN_VERIFIED;
       syncReady = true;
     }
     fxaEmailAddressLabels.forEach((label) => {
       let l10nAttrs = document.l10n.getAttributes(label);
-      document.l10n.setAttributes(l10nAttrs.id, {email: state.email});
+      document.l10n.setAttributes(label, l10nAttrs.id, {email: state.email});
     });
     document.getElementById("fxaEmailAddress").textContent = state.email;
 
     this._populateComputerName(Weave.Service.clientsEngine.localName);
     let engines = document.getElementById("fxaSyncEngines");
     for (let checkbox of engines.querySelectorAll("checkbox")) {
       checkbox.disabled = !syncReady;
     }