Bug 1503341 - Use UX provided text for displaying errors when writing the update settings json file. r=bytesized,flod
authorRobert Strong <robert.bugzilla@gmail.com>
Tue, 28 May 2019 17:36:16 +0000
changeset 475930 7317c8900a8b0e146946358c1e05b8c3fb9f942d
parent 475929 b070e48e2a477464d3fd5f4e0e0d6e3e947e478d
child 475931 c22d5fec86279089d33bea9a356bbd3f310a4f8b
push id36080
push usernerli@mozilla.com
push dateWed, 29 May 2019 09:48:47 +0000
treeherdermozilla-central@d78adc84bde8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbytesized, flod
bugs1503341
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1503341 - Use UX provided text for displaying errors when writing the update settings json file. r=bytesized,flod Differential Revision: https://phabricator.services.mozilla.com/D32637
browser/components/preferences/in-content/main.js
browser/locales/en-US/browser/preferences/preferences.ftl
--- a/browser/components/preferences/in-content/main.js
+++ b/browser/components/preferences/in-content/main.js
@@ -1369,18 +1369,18 @@ var gMainPane = {
       if (!updateAutoValue) {
         await this.checkUpdateInProgress();
       }
     }
   },
 
   async reportUpdatePrefWriteError(error) {
     let [title, message] = await document.l10n.formatValues([
-      {id: "update-pref-write-failure-title"},
-      {id: "update-pref-write-failure-message", args: {path: error.path}},
+      {id: "update-setting-write-failure-title"},
+      {id: "update-setting-write-failure-message", args: {path: error.path}},
     ]);
 
     // Set up the Ok Button
     let buttonFlags = (Services.prompt.BUTTON_POS_0 *
                        Services.prompt.BUTTON_TITLE_OK);
     Services.prompt.confirmEx(window, title, message, buttonFlags,
                               null, null, null, null, {});
   },
--- a/browser/locales/en-US/browser/preferences/preferences.ftl
+++ b/browser/locales/en-US/browser/preferences/preferences.ftl
@@ -355,21 +355,26 @@ update-application-warning-cross-user-se
 update-application-use-service =
     .label = Use a background service to install updates
     .accesskey = b
 
 update-enable-search-update =
     .label = Automatically update search engines
     .accesskey = e
 
-update-pref-write-failure-title = Write Failure
+update-setting-write-failure-title = Error saving Update preferences
 
 # Variables:
 #   $path (String) - Path to the configuration file
-update-pref-write-failure-message = Unable to save preference. Could not write to file: { $path }
+# The newlines between the main text and the line containing the path is
+# intentional so the path is easier to identify.
+update-setting-write-failure-message =
+    { -brand-short-name } encountered an error and didn’t save this change. Note that setting this update preference requires permission to write to the file below. You or a system administrator may be able resolve the error by granting the Users group full control to this file.
+
+    Could not write to file: { $path }
 
 update-in-progress-title = Update In Progress
 
 update-in-progress-message = Do you want { -brand-short-name } to continue with this update?
 
 update-in-progress-ok-button = &Discard
 # Continue is the cancel button so pressing escape or using a platform standard
 # method of closing the UI will not discard the update.