Bug 1280370 - Remove unneeded DomainIsWildcard check r=mixedpuppy
authorRob Wu <rob@robwu.nl>
Wed, 08 Aug 2018 18:56:53 +0200
changeset 430586 72dd828f24817614cd30c1156b99b58b73f9f5e7
parent 430585 d01b3ac48bdc327764b63c21400e6abb7d53cb85
child 430587 76af74df176a02585d804fdaa1e688cbe4c06c6e
push id34409
push usertoros@mozilla.com
push dateThu, 09 Aug 2018 10:00:05 +0000
treeherdermozilla-central@eb9ff7de69ef [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy
bugs1280370
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1280370 - Remove unneeded DomainIsWildcard check r=mixedpuppy The DomainIsWildcard check is already covered by MatchesDomain.
toolkit/components/extensions/MatchPattern.cpp
--- a/toolkit/components/extensions/MatchPattern.cpp
+++ b/toolkit/components/extensions/MatchPattern.cpp
@@ -427,17 +427,17 @@ MatchPattern::Matches(const URLInfo& aUR
   if (aExplicit && mMatchSubdomain) {
     return false;
   }
 
   if (!mSchemes->Contains(aURL.Scheme())) {
     return false;
   }
 
-  if (!DomainIsWildcard() && !MatchesDomain(aURL.Host())) {
+  if (!MatchesDomain(aURL.Host())) {
     return false;
   }
 
   if (mPath && !mPath->IsWildcard() && !mPath->Matches(aURL.Path())) {
     return false;
   }
 
   return true;