Bug 1546512 - fix incorrect stagingFailed check. r=bytesized
authorRobert Strong <robert.bugzilla@gmail.com>
Tue, 23 Apr 2019 21:24:35 +0000
changeset 470564 72dc7deb89f60941a661ab5ff04d9ade077b7a4d
parent 470563 c2a0278aa9ec56ff75ba7a96ee68f3d61b6a1a9f
child 470565 f04be3819486bf2718564654284a921f56b0b570
push id35908
push useraciure@mozilla.com
push dateWed, 24 Apr 2019 04:28:40 +0000
treeherdermozilla-central@c9f0730a57a6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbytesized
bugs1546512
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1546512 - fix incorrect stagingFailed check. r=bytesized Differential Revision: https://phabricator.services.mozilla.com/D28567
toolkit/mozapps/update/UpdateService.jsm
--- a/toolkit/mozapps/update/UpdateService.jsm
+++ b/toolkit/mozapps/update/UpdateService.jsm
@@ -3802,17 +3802,17 @@ Downloader.prototype = {
           state == STATE_APPLIED_SERVICE) {
         LOG("Downloader:_selectPatch - already downloaded");
         return null;
       }
 
       selectedPatch.QueryInterface(Ci.nsIWritablePropertyBag);
       if (selectedPatch.getProperty("bitsResult") != null &&
           selectedPatch.getProperty("internalResult") == null &&
-          selectedPatch.getProperty("stagingFailed") != null) {
+          selectedPatch.getProperty("stagingFailed") == null) {
         LOG("Downloader:_selectPatch - Falling back to non-BITS download " +
             "mechanism due to existing BITS result: " +
             selectedPatch.getProperty("bitsResult"));
         return selectedPatch;
       }
 
       if (update && selectedPatch.type == "complete") {
         // This is a pretty fatal error.  Just bail.