Bug 1453795 - DevTools - Initialize member fields in classes/ structures. r=jimb
authorAndi-Bogdan Postelnicu <bpostelnicu@mozilla.com>
Sat, 16 Jun 2018 15:36:55 +0300
changeset 423177 72106854c71e6f19bf109ea967a0017662bd561b
parent 423176 2bc9dd454c785ef5498a768f3d2c8c169757f81d
child 423178 aa34ca78ad4d508e4e1c7a8ba0f278a5f83658bc
push id34164
push usercsabou@mozilla.com
push dateThu, 21 Jun 2018 01:17:13 +0000
treeherdermozilla-central@d231a3231680 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimb
bugs1453795
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1453795 - DevTools - Initialize member fields in classes/ structures. r=jimb
devtools/shared/heapsnapshot/AutoMemMap.h
devtools/shared/heapsnapshot/HeapSnapshot.cpp
tools/rewriting/ThirdPartyPaths.txt
--- a/devtools/shared/heapsnapshot/AutoMemMap.h
+++ b/devtools/shared/heapsnapshot/AutoMemMap.h
@@ -40,17 +40,18 @@ class MOZ_RAII AutoMemMap
   PRFileMap*   fileMap;
   void*        addr;
 
   AutoMemMap(const AutoMemMap& aOther) = delete;
   void operator=(const AutoMemMap& aOther) = delete;
 
 public:
   explicit AutoMemMap(MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM)
-      : fd(nullptr)
+      : fileInfo()
+      , fd(nullptr)
       , fileMap(nullptr)
       , addr(nullptr)
   {
       MOZ_GUARD_OBJECT_NOTIFIER_INIT;
   };
   ~AutoMemMap();
 
   // Initialize this AutoMemMap.
--- a/devtools/shared/heapsnapshot/HeapSnapshot.cpp
+++ b/devtools/shared/heapsnapshot/HeapSnapshot.cpp
@@ -1354,17 +1354,19 @@ class MOZ_STACK_CLASS HeapSnapshotHandle
 public:
   // For telemetry.
   uint32_t nodeCount;
   uint32_t edgeCount;
 
   HeapSnapshotHandler(CoreDumpWriter& writer,
                       JS::CompartmentSet* compartments)
     : writer(writer),
-      compartments(compartments)
+      compartments(compartments),
+      nodeCount(0),
+      edgeCount(0)
   { }
 
   // JS::ubi::BreadthFirst handler interface.
 
   class NodeData { };
   typedef JS::ubi::BreadthFirst<HeapSnapshotHandler> Traversal;
   bool operator() (Traversal& traversal,
                    JS::ubi::Node origin,
--- a/tools/rewriting/ThirdPartyPaths.txt
+++ b/tools/rewriting/ThirdPartyPaths.txt
@@ -1,13 +1,15 @@
 browser/components/translation/cld2/
 browser/extensions/mortar/ppapi/
 db/sqlite3/src/
 devtools/client/sourceeditor/codemirror/
 devtools/client/sourceeditor/tern/
+devtools/shared/heapsnapshot/CoreDump.pb.cc
+devtools/shared/heapsnapshot/CoreDump.pb.h
 editor/libeditor/tests/browserscope/lib/richtext/
 editor/libeditor/tests/browserscope/lib/richtext2/
 extensions/spellcheck/hunspell/src/
 gfx/angle/
 gfx/cairo/
 gfx/graphite2/
 gfx/harfbuzz/
 gfx/ots/