Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor
authorMike Hommey <mh+mozilla@glandium.org>
Tue, 04 Jun 2019 11:39:44 +0000
changeset 476886 71d3424191f63751068077270a32f9f3aeb026b8
parent 476885 894b83e9960615505910a674690222e1f9c74f50
child 476887 3149eddf5db567f05556ea198d1ceccffdb4c490
push id36110
push usermalexandru@mozilla.com
push dateWed, 05 Jun 2019 09:49:10 +0000
treeherdermozilla-central@31cec3975dd0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1556662, 1469091
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1556662 - Fix a typo in change from bug 1469091. r=dmajor In a branch for `isinstance(obj, (HostSources, HostGeneratedSources))`, `isinstance(obj, GeneratedSources)` is clearly not going to match anything. `isinstance(obj, HostGeneratedSources)` is what was intended. Differential Revision: https://phabricator.services.mozilla.com/D33603
python/mozbuild/mozbuild/backend/recursivemake.py
--- a/python/mozbuild/mozbuild/backend/recursivemake.py
+++ b/python/mozbuild/mozbuild/backend/recursivemake.py
@@ -480,17 +480,17 @@ class RecursiveMakeBackend(CommonBackend
                     backend_file.write('%s += %s\n' % (var, f))
         elif isinstance(obj, (HostSources, HostGeneratedSources)):
             suffix_map = {
                 '.c': 'HOST_CSRCS',
                 '.mm': 'HOST_CMMSRCS',
                 '.cpp': 'HOST_CPPSRCS',
             }
             variables = [suffix_map[obj.canonical_suffix]]
-            if isinstance(obj, GeneratedSources):
+            if isinstance(obj, HostGeneratedSources):
                 variables.append('GARBAGE')
                 base = backend_file.objdir
             else:
                 base = backend_file.srcdir
             for f in sorted(obj.files):
                 f = mozpath.relpath(f, base)
                 for var in variables:
                     backend_file.write('%s += %s\n' % (var, f))