Bug 1586717 - Making the test 'browser/components/originattributes/test/browser/browser_favicon_firstParty.js' working in Fission. r=baku
authorTim Huang <tihuang@mozilla.com>
Tue, 15 Oct 2019 14:27:01 +0000
changeset 498337 71818704a2cacc8e7f2fc23534ae00527a73a3b4
parent 498336 0793db7c027025ed3f44e899f65fd26e676158d5
child 498338 4431f798179ba4a15137e03ca3d2a604c754b26b
push id36717
push usernbeleuzu@mozilla.com
push dateMon, 21 Oct 2019 21:51:55 +0000
treeherdermozilla-central@563f437f24b9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbaku
bugs1586717
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1586717 - Making the test 'browser/components/originattributes/test/browser/browser_favicon_firstParty.js' working in Fission. r=baku Depends on D49252 Differential Revision: https://phabricator.services.mozilla.com/D49253
browser/components/originattributes/test/browser/browser.ini
browser/components/originattributes/test/browser/browser_favicon_firstParty.js
--- a/browser/components/originattributes/test/browser/browser.ini
+++ b/browser/components/originattributes/test/browser/browser.ini
@@ -62,17 +62,16 @@ support-files =
   worker_deblobify.js
   !/toolkit/content/tests/browser/common/mockTransfer.js
 
 [browser_broadcastChannel.js]
 [browser_cache.js]
 skip-if = verify
 [browser_cookieIsolation.js]
 [browser_favicon_firstParty.js]
-fail-if = fission
 [browser_favicon_userContextId.js]
 fail-if = fission
 [browser_firstPartyIsolation.js]
 skip-if = fission || debug #Bug 1345346
 [browser_firstPartyIsolation_about_newtab.js]
 [browser_firstPartyIsolation_aboutPages.js]
 fail-if = fission
 [browser_firstPartyIsolation_blobURI.js]
--- a/browser/components/originattributes/test/browser/browser_favicon_firstParty.js
+++ b/browser/components/originattributes/test/browser/browser_favicon_firstParty.js
@@ -201,17 +201,19 @@ async function openTab(aURL) {
 }
 
 async function assignCookiesUnderFirstParty(aURL, aFirstParty, aCookieValue) {
   // Open a tab under the given aFirstParty, and this tab will have an
   // iframe which loads the aURL.
   let tabInfo = await openTabInFirstParty(aURL, aFirstParty);
 
   // Add cookies into the iframe.
-  await ContentTask.spawn(tabInfo.browser, aCookieValue, async function(value) {
+  await SpecialPowers.spawn(tabInfo.browser, [aCookieValue], async function(
+    value
+  ) {
     content.document.cookie = value;
   });
 
   BrowserTestUtils.removeTab(tabInfo.tab);
 }
 
 async function generateCookies(aThirdParty) {
   // we generate two different cookies for two first party domains.