Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell
authorMicah Tigley <mtigley@mozilla.com>
Wed, 09 Feb 2022 00:21:14 +0000
changeset 607206 70ea492ad2456aed1d741ec39e04c06757a24b3e
parent 607205 054b40d42ff5263567f998e0bbbe8b71a617b1c3
child 607207 7941091cc105359eeb6af6bbd8375ea3f1762123
push id39262
push userabutkovits@mozilla.com
push dateWed, 09 Feb 2022 09:56:40 +0000
treeherdermozilla-central@99073046b39c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhowell
bugs1753401
milestone99.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1753401 - Change PiP toggle's visibility threshold back to 1.0. r=mhowell Differential Revision: https://phabricator.services.mozilla.com/D138218
browser/app/profile/firefox.js
toolkit/actors/PictureInPictureChild.jsm
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1736,17 +1736,17 @@ pref("media.autoplay.default", 1); // 0=
   // Block WebAudio from playing automatically.
   pref("media.autoplay.block-webaudio", true);
 #else
   pref("media.autoplay.block-webaudio", false);
 #endif
 
 pref("media.videocontrols.picture-in-picture.enabled", true);
 pref("media.videocontrols.picture-in-picture.video-toggle.enabled", true);
-pref("media.videocontrols.picture-in-picture.video-toggle.visibility-threshold", "0.9");
+pref("media.videocontrols.picture-in-picture.video-toggle.visibility-threshold", "1.0");
 pref("media.videocontrols.picture-in-picture.keyboard-controls.enabled", true);
 
 #ifdef NIGHTLY_BUILD
   // Show the audio toggle for Picture-in-Picture.
   pref("media.videocontrols.picture-in-picture.audio-toggle.enabled", true);
   // Enable keyboard controls for Picture-in-Picture.
 #else
   pref("media.videocontrols.picture-in-picture.audio-toggle.enabled", false);
--- a/toolkit/actors/PictureInPictureChild.jsm
+++ b/toolkit/actors/PictureInPictureChild.jsm
@@ -257,17 +257,17 @@ class PictureInPictureToggleChild extend
     if (this.isDestroyed || !this.document) {
       return false;
     }
 
     let state = this.weakDocStates.get(this.document);
 
     let visibilityThresholdPref = Services.prefs.getFloatPref(
       TOGGLE_VISIBILITY_THRESHOLD_PREF,
-      "0.9"
+      "1.0"
     );
 
     if (!state) {
       state = {
         // A reference to the IntersectionObserver that's monitoring for videos
         // to become visible.
         intersectionObserver: null,
         // A WeakSet of videos that are supposedly visible, according to the
@@ -911,17 +911,17 @@ class PictureInPictureToggleChild extend
       // We cache the matchers process-wide. We'll skip this while running tests to make that
       // easier.
       let siteOverrides = this.toggleTesting
         ? PictureInPictureToggleChild.getSiteOverrides()
         : gSiteOverrides;
 
       let visibilityThresholdPref = Services.prefs.getFloatPref(
         TOGGLE_VISIBILITY_THRESHOLD_PREF,
-        "0.9"
+        "1.0"
       );
 
       // Do we have any toggle overrides? If so, try to apply them.
       for (let [override, { policy, visibilityThreshold }] of siteOverrides) {
         if (
           (policy || visibilityThreshold) &&
           override.matches(this.document.documentURI)
         ) {