Bug 1623858: part 9) Document more variables corresponding to `nsISelectionController::getDisplaySelection`. r=smaug
authorMirko Brodesser <mbrodesser@mozilla.com>
Tue, 24 Mar 2020 20:27:24 +0000
changeset 520335 70e7b2baa28fc189985aea36b3819e953dba731f
parent 520334 8a460e00bd6d6ee6945610fb33130ad4fc8db757
child 520336 0c79992b340e1181ce949686c1eba6b6cf5d79c5
push id37248
push userbtara@mozilla.com
push dateWed, 25 Mar 2020 16:40:49 +0000
treeherdermozilla-central@c5112a7573ac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1623858
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1623858: part 9) Document more variables corresponding to `nsISelectionController::getDisplaySelection`. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D67847
layout/generic/nsFrame.cpp
--- a/layout/generic/nsFrame.cpp
+++ b/layout/generic/nsFrame.cpp
@@ -2315,16 +2315,19 @@ int16_t nsFrame::DetermineDisplaySelecti
       }
     }
   }
   return selType;
 }
 
 class nsDisplaySelectionOverlay : public nsPaintedDisplayItem {
  public:
+  /**
+   * @param aSelectionValue nsISelectionController::getDisplaySelection.
+   */
   nsDisplaySelectionOverlay(nsDisplayListBuilder* aBuilder, nsFrame* aFrame,
                             int16_t aSelectionValue)
       : nsPaintedDisplayItem(aBuilder, aFrame),
         mSelectionValue(aSelectionValue) {
     MOZ_COUNT_CTOR(nsDisplaySelectionOverlay);
   }
   MOZ_COUNTED_DTOR_OVERRIDE(nsDisplaySelectionOverlay)
 
@@ -2337,16 +2340,17 @@ class nsDisplaySelectionOverlay : public
       nsDisplayListBuilder* aDisplayListBuilder) override;
   NS_DISPLAY_DECL_NAME("SelectionOverlay", TYPE_SELECTION_OVERLAY)
  private:
   DeviceColor ComputeColor() const;
 
   static DeviceColor ComputeColorFromSelectionStyle(ComputedStyle&);
   static DeviceColor ApplyTransparencyIfNecessary(nscolor);
 
+  // nsISelectionController::getDisplaySelection.
   int16_t mSelectionValue;
 };
 
 DeviceColor nsDisplaySelectionOverlay::ApplyTransparencyIfNecessary(
     nscolor aColor) {
   // If it has already alpha, leave it like that.
   if (NS_GET_A(aColor) != 255) {
     return ToDeviceColor(aColor);