Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert
authorEmilio Cobos Álvarez <emilio@crisal.io>
Thu, 02 May 2019 15:19:10 +0000
changeset 472365 704947d53e4c48d1b6f208eb551bb35207fb10ca
parent 472364 8141f59dd1237917e845f055f63395753dcea70b
child 472366 bb38c692e51911b0de25bd9846f0ac79aa593176
push id35954
push userrgurzau@mozilla.com
push dateFri, 03 May 2019 04:14:31 +0000
treeherdermozilla-central@d7b02bc7cf44 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1521253, 1547939
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1521253 - Request longer timeouts in two tests that frequently time out in the Android emulator. r=dholbert Bug 1547939 added a bunch of extra tests for three properties (background, mask, and -webkit-mask). This made them time out more frequently in the Android emulator. Request a longer timeout to address this. Alternative is maybe just removing the tests or such, I don't think they're of particularly great value. Differential Revision: https://phabricator.services.mozilla.com/D29650
layout/style/test/test_garbage_at_end_of_declarations.html
layout/style/test/test_property_syntax_errors.html
--- a/layout/style/test/test_garbage_at_end_of_declarations.html
+++ b/layout/style/test/test_garbage_at_end_of_declarations.html
@@ -124,16 +124,17 @@ function test_property(property)
     test_value(info.initial_values[idx]);
   for (idx in info.other_values)
     test_value(info.other_values[idx]);
 }
 
 // To avoid triggering the slow script dialog, we have to test one
 // property at a time.
 SimpleTest.waitForExplicitFinish();
+SimpleTest.requestLongerTimeout(2);
 var props = [];
 for (var prop in gCSSProperties)
   props.push(prop);
 props = props.reverse();
 function do_one() {
   if (props.length == 0) {
     SimpleTest.finish();
     return;
--- a/layout/style/test/test_property_syntax_errors.html
+++ b/layout/style/test/test_property_syntax_errors.html
@@ -14,18 +14,18 @@
 <div id="content" style="display: none">
 
 <div id="testnode"></div>
   
 </div>
 <pre id="test">
 <script class="testbody" type="text/javascript">
 
-SimpleTest.requestLongerTimeout(2);
 SimpleTest.waitForExplicitFinish();
+SimpleTest.requestLongerTimeout(4);
 
 function check_not_accepted(decl, property, info, badval)
 {
   decl.setProperty(property, badval, "");
 
   is(decl.getPropertyValue(property), "",
      "invalid value '" + badval + "' not accepted for '" + property +
      "' property");