Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander
authorMichael Comella <michael.l.comella@gmail.com>
Wed, 03 Jun 2015 21:12:00 -0700
changeset 247135 6f9c8836751721ba65c42aeef6293604b0dd62f3
parent 247134 19ab36f587166107f3c0a3c384f81e8c17d63708
child 247136 6657b144de7c648e7023078fbbbf7105b0da0985
push id28854
push userryanvm@gmail.com
push dateThu, 04 Jun 2015 13:24:20 +0000
treeherdermozilla-central@5b4c240e1a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1170285
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1170285 - Add lint.xml config file to base sub-project. r?nalexander While it might seem like a good idea to disable all of the checks we don't currently pass, Intellij uses the same lint configuration file as the command-line invocation and so we'll be more likely to write in new errors by disabling some checks.
mobile/android/gradle/base/lint.xml
mobile/android/mach_commands.py
new file mode 100644
--- /dev/null
+++ b/mobile/android/gradle/base/lint.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <!-- Enable relevant checks disabled by default -->
+    <issue id="NegativeMargin" severity="warning" />
+</lint>
--- a/mobile/android/mach_commands.py
+++ b/mobile/android/mach_commands.py
@@ -125,16 +125,17 @@ class MachCommands(MachCommandBase):
         srcdir('app/src/robocop_harness/org/mozilla/gecko', 'build/mobile/robocop')
         srcdir('app/src/robocop/org/mozilla/gecko/tests', 'mobile/android/tests/browser/robocop')
         srcdir('app/src/background/org/mozilla/gecko', 'mobile/android/tests/background/junit3/src')
         srcdir('app/src/browser/org/mozilla/gecko', 'mobile/android/tests/browser/junit3/src')
         # Test libraries.
         srcdir('app/libs', 'build/mobile/robocop')
 
         srcdir('base/build.gradle', 'mobile/android/gradle/base/build.gradle')
+        srcdir('base/lint.xml', 'mobile/android/gradle/base/lint.xml')
         srcdir('base/src/main/AndroidManifest.xml', 'mobile/android/gradle/base/AndroidManifest.xml')
         srcdir('base/src/main/java/org/mozilla/gecko', 'mobile/android/base')
         srcdir('base/src/main/java/org/mozilla/mozstumbler', 'mobile/android/stumbler/java/org/mozilla/mozstumbler')
         srcdir('base/src/main/java/org/mozilla/search', 'mobile/android/search/java/org/mozilla/search')
         srcdir('base/src/main/res', 'mobile/android/base/resources')
         srcdir('base/src/crashreporter/res', 'mobile/android/base/crashreporter/res')
 
         manifest_path = os.path.join(self.topobjdir, 'mobile', 'android', 'gradle.manifest')