Bug 1437533 - Properly declare JSTracer respecting JS_PUBLIC_API to avoid compile errors about visibility mismatch in non-unified builds. r=jorendorff
authorJeff Walden <jwalden@mit.edu>
Mon, 12 Mar 2018 12:56:39 -0700
changeset 410755 6e15ed6f59148d126a692135793663b1e04a3b04
parent 410754 223010e3a593311128b4faa732362d69c801d57b
child 410756 92d1872f4a238b7f1bdfb0cc92432928bf619af0
push id33736
push usershindli@mozilla.com
push dateFri, 30 Mar 2018 09:56:41 +0000
treeherdermozilla-central@b7fa9d95150e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
bugs1437533
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1437533 - Properly declare JSTracer respecting JS_PUBLIC_API to avoid compile errors about visibility mismatch in non-unified builds. r=jorendorff
js/public/ProfilingStack.h
--- a/js/public/ProfilingStack.h
+++ b/js/public/ProfilingStack.h
@@ -10,17 +10,27 @@
 #include <algorithm>
 #include <stdint.h>
 
 #include "jstypes.h"
 
 #include "js/TypeDecls.h"
 #include "js/Utility.h"
 
-class JSTracer;
+#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wattributes"
+#endif // JS_BROKEN_GCC_ATTRIBUTE_WARNING
+
+class JS_PUBLIC_API(JSTracer);
+
+#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
+#pragma GCC diagnostic pop
+#endif // JS_BROKEN_GCC_ATTRIBUTE_WARNING
+
 class PseudoStack;
 
 // This file defines the classes PseudoStack and ProfileEntry.
 // The PseudoStack manages an array of ProfileEntries.
 // Usage:
 //
 //  PseudoStack* pseudoStack = ...;
 //