Bug 1612973 - allow opaque images to use the fast image shader. r=nical
authorLee Salzman <lsalzman@mozilla.com>
Tue, 04 Feb 2020 09:14:52 +0000
changeset 512456 6deaa5a356b2106c4393357b365280ca54ca7d22
parent 512455 a117660624ec1117687f8922ee8f0b84361654f9
child 512457 b21826332184a16c6abbaadd2fe3c88f0522d105
push id37090
push userdluca@mozilla.com
push dateTue, 04 Feb 2020 21:43:24 +0000
treeherdermozilla-central@8d9e413f9465 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1612973
milestone74.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1612973 - allow opaque images to use the fast image shader. r=nical Differential Revision: https://phabricator.services.mozilla.com/D61508
gfx/wr/webrender/src/shade.rs
--- a/gfx/wr/webrender/src/shade.rs
+++ b/gfx/wr/webrender/src/shade.rs
@@ -931,18 +931,17 @@ impl Shaders {
             }
             BatchKind::Brush(brush_kind) => {
                 let brush_shader = match brush_kind {
                     BrushBatchKind::Solid => {
                         &mut self.brush_solid
                     }
                     BrushBatchKind::Image(image_buffer_kind) => {
                         if features.contains(BatchFeatures::ANTIALIASING) ||
-                            features.contains(BatchFeatures::REPETITION) ||
-                            !features.contains(BatchFeatures::ALPHA_PASS) {
+                            features.contains(BatchFeatures::REPETITION) {
 
                             self.brush_image[image_buffer_kind as usize]
                                 .as_mut()
                                 .expect("Unsupported image shader kind")
                         } else {
                             self.brush_fast_image[image_buffer_kind as usize]
                                 .as_mut()
                                 .expect("Unsupported image shader kind")