Bug 842772 - Followup to address review comments.
authorCameron McCormack <cam@mcc.id.au>
Wed, 20 Feb 2013 11:58:25 +1100
changeset 122391 6d504df6f023173832683178f62e25d6e894be4d
parent 122390 18fa6e840300a79004c0c87108de235efffcc245
child 122392 e8c8d9373eba3573dfaaf5ce90419eb574ac4722
push id24336
push userryanvm@gmail.com
push dateWed, 20 Feb 2013 12:07:46 +0000
treeherdermozilla-central@1bcc3c56b011 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs842772
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 842772 - Followup to address review comments.
layout/style/test/ListCSSProperties.cpp
--- a/layout/style/test/ListCSSProperties.cpp
+++ b/layout/style/test/ListCSSProperties.cpp
@@ -59,17 +59,17 @@ const PropertyInfo gShorthandProperties[
 
 #include "nsCSSPropList.h"
 
 #undef CSS_PROP_SHORTHAND
 #undef LISTCSSPROPERTIES_INNER_MACRO
 #undef CSS_PROP_DOMPROP_PREFIXED
 
 #define CSS_PROP_ALIAS(name_, id_, method_, pref_) \
-    { #name_, #method_, #pref_ },
+    { #name_, #method_, pref_ },
 
 #include "nsCSSPropAliasList.h"
 
 #undef CSS_PROP_ALIAS
 
 };
 
 /* see gLonghandPropertiesWithDOMProp */
@@ -187,23 +187,18 @@ print_array(const char *aName,
         else {
             ++j;
             if (strncmp(p->domName, "Moz", 3) == 0)
                 printf("\"%s\"", p->domName);
             else
                 // lowercase the first letter
                 printf("\"%c%s\"", p->domName[0] + 32, p->domName + 1);
         }
-        if (p->pref && p->pref[0]) {
-            printf(", pref: ");
-            if (p->pref[0] == '\"') {
-                printf("%s", p->pref);
-            } else {
-                printf("\"%s\"", p->pref);
-            }
+        if (p->pref[0]) {
+            printf(", pref: \"%s\"", p->pref);
         }
         printf(" }");
     }
 
     if (j != aDOMPropsLength) {
         fprintf(stderr, "Assertion failure %s:%d\n", __FILE__, __LINE__);
         fprintf(stderr, "j==%d, aDOMPropsLength == %d\n", j, aDOMPropsLength);
         exit(1);