Bug 1518834 - Don't disable pulling when stopping microphone source. r=drno
authorAndreas Pehrson <apehrson@mozilla.com>
Thu, 10 Jan 2019 06:13:25 +0000
changeset 453208 6d3e6c915370bc5e771429c0a207950db64b7089
parent 453207 74bb778f78793e82cfcae11446387795cb4d4180
child 453209 460f0359741bd0026b7da0426836e1c0084a5be3
push id35349
push userbtara@mozilla.com
push dateThu, 10 Jan 2019 17:19:27 +0000
treeherdermozilla-central@a51746f37520 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdrno
bugs1518834
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518834 - Don't disable pulling when stopping microphone source. r=drno Differential Revision: https://phabricator.services.mozilla.com/D16148
dom/media/webrtc/MediaEngineWebRTCAudio.cpp
--- a/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
+++ b/dom/media/webrtc/MediaEngineWebRTCAudio.cpp
@@ -601,22 +601,21 @@ nsresult MediaEngineWebRTCMicrophoneSour
 
   if (mState == kStopped) {
     // Already stopped - this is allowed
     return NS_OK;
   }
 
   RefPtr<MediaEngineWebRTCMicrophoneSource> that = this;
   NS_DispatchToMainThread(
-      media::NewRunnableFrom([that, stream = mStream, track = mTrackID]() {
+      media::NewRunnableFrom([that, stream = mStream]() {
         if (stream->IsDestroyed()) {
           return NS_OK;
         }
 
-        stream->SetPullingEnabled(track, false);
         stream->GraphImpl()->AppendMessage(MakeUnique<StartStopMessage>(
             that->mInputProcessing, StartStopMessage::Stop));
         CubebUtils::AudioDeviceID deviceID = that->mDeviceInfo->DeviceID();
         Maybe<CubebUtils::AudioDeviceID> id = Some(deviceID);
         stream->CloseAudioInput(id, that->mInputProcessing);
 
         return NS_OK;
       }));