Bug 473269 - Stop using swap, and start using forget; r=sdwilsh
authorNilay Vaish <nilayvaish@yahoo.com>
Tue, 03 Feb 2009 15:42:26 +0100
changeset 24555 6d123d6a104ac0a5eaffdc98e91c0148ee7d9f0f
parent 24554 13b5a7af35bbf3f026ef44577db05615a6133cde
child 24556 c23d77b0d600caf566adb12736ef7adfc3fe106e
push id5113
push usersgautherie.bz@free.fr
push dateTue, 03 Feb 2009 14:44:19 +0000
treeherdermozilla-central@c23d77b0d600 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssdwilsh
bugs473269
milestone1.9.2a1pre
Bug 473269 - Stop using swap, and start using forget; r=sdwilsh
toolkit/components/downloads/src/nsDownloadManager.cpp
--- a/toolkit/components/downloads/src/nsDownloadManager.cpp
+++ b/toolkit/components/downloads/src/nsDownloadManager.cpp
@@ -1347,17 +1347,17 @@ nsDownloadManager::GetDefaultDownloadsDi
   rv = dirService->Get(NS_OS_HOME_DIR,
                        NS_GET_IID(nsILocalFile),
                        getter_AddRefs(downloadDir));
   NS_ENSURE_SUCCESS(rv, rv);
   rv = downloadDir->Append(folderName);
   NS_ENSURE_SUCCESS(rv, rv);
 #endif
 
-  downloadDir.swap(*aResult);
+  downloadDir.forget(aResult);
 
   return NS_OK;
 }
 
 #define NS_BRANCH_DOWNLOAD     "browser.download."
 #define NS_PREF_FOLDERLIST     "folderList"
 #define NS_PREF_DIR            "dir"
 
@@ -1389,17 +1389,17 @@ nsDownloadManager::GetUserDownloadsDirec
         nsCOMPtr<nsILocalFile> downloadDir;
         nsCOMPtr<nsIProperties> dirService =
            do_GetService(NS_DIRECTORY_SERVICE_CONTRACTID, &rv);
         NS_ENSURE_SUCCESS(rv, rv);
         rv = dirService->Get(NS_OS_DESKTOP_DIR,
                              NS_GET_IID(nsILocalFile),
                              getter_AddRefs(downloadDir));
         NS_ENSURE_SUCCESS(rv, rv);
-        downloadDir.swap(*aResult);
+        downloadDir.forget(aResult);
         return NS_OK;
       }
       break;
     case 1: // Downloads
       return GetDefaultDownloadsDirectory(aResult);
     case 2: // Custom
       {
         nsCOMPtr<nsILocalFile> customDirectory;
@@ -1408,31 +1408,31 @@ nsDownloadManager::GetUserDownloadsDirec
                                     getter_AddRefs(customDirectory));
         if (customDirectory) {
           PRBool exists = PR_FALSE;
           (void)customDirectory->Exists(&exists);
 
           if (!exists) {
             rv = customDirectory->Create(nsIFile::DIRECTORY_TYPE, 0755);
             if (NS_SUCCEEDED(rv)) {
-              customDirectory.swap(*aResult);
+              customDirectory.forget(aResult);
               return NS_OK;
             }
 
             // Create failed, so it still doesn't exist.  Fall out and get the
             // default downloads directory.
           }
 
           PRBool writable = PR_FALSE;
           PRBool directory = PR_FALSE;
           (void)customDirectory->IsWritable(&writable);
           (void)customDirectory->IsDirectory(&directory);
 
           if (exists && writable && directory) {
-            customDirectory.swap(*aResult);
+            customDirectory.forget(aResult);
             return NS_OK;
           }
         }
         rv = GetDefaultDownloadsDirectory(aResult);
         if (NS_SUCCEEDED(rv)) {
           (void)prefBranch->SetComplexValue(NS_PREF_DIR,
                                             NS_GET_IID(nsILocalFile),
                                             *aResult);