Bug 1561435 - Fix linting errors for security/, r=standard8
authorVictor Porof <vporof@mozilla.com>
Fri, 21 Jun 2019 16:21:34 -0700
changeset 481409 6ceb52b9a600947561a2f5495bbac8c262003e81
parent 481408 8062fdb434272ca7620c9caae8d3b8a5096c9f46
child 481410 854373e1ab9e7a438d9a666d76d4cfd227a7e0ae
push id36243
push uservporof@mozilla.com
push dateFri, 05 Jul 2019 14:04:25 +0000
treeherdermozilla-central@041abaa4aa85 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersstandard8
bugs1561435
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1561435 - Fix linting errors for security/, r=standard8 # ignore-this-changeset Differential Revision: https://phabricator.services.mozilla.com/D35929
security/manager/ssl/tests/mochitest/browser/browser_exportP12_passwordUI.js
security/manager/ssl/tests/unit/test_ocsp_caching.js
security/manager/tools/genHPKPStaticPins.js
security/manager/tools/genRootCAHashes.js
--- a/security/manager/ssl/tests/mochitest/browser/browser_exportP12_passwordUI.js
+++ b/security/manager/ssl/tests/mochitest/browser/browser_exportP12_passwordUI.js
@@ -115,17 +115,17 @@ add_task(async function testPasswordStre
       win.document.documentElement.getButton("accept").disabled,
       password1Textbox.value != password2Textbox.value,
       "Actual and expected accept button disable state should " +
         `match for ${testCase.name}`
     );
     Assert.equal(
       strengthProgressBar.value,
       testCase.strength,
-      "Actual and expected strength value should match for" + `${testCase.name}`
+      `Actual and expected strength value should match for ${testCase.name}`
     );
   }
 
   await BrowserTestUtils.closeWindow(win);
 });
 
 // Test that the right values are returned when the dialog is accepted.
 add_task(async function testAcceptDialogReturnValues() {
--- a/security/manager/ssl/tests/unit/test_ocsp_caching.js
+++ b/security/manager/ssl/tests/unit/test_ocsp_caching.js
@@ -150,17 +150,17 @@ function add_tests() {
   // ocsp-stapling-unknown.example.com and ocsp-stapling-none.example.com.
 
   // Get an Unknown response for the *.example.com cert and put it in the
   // OCSP cache.
   add_ocsp_test(
     "ocsp-stapling-unknown.example.com",
     SEC_ERROR_OCSP_UNKNOWN_CERT,
     [],
-    "Stapled Unknown response -> a fetch should not have been" + " attempted"
+    "Stapled Unknown response -> a fetch should not have been attempted"
   );
 
   // A failure to retrieve an OCSP response must result in the cached Unknown
   // response being recognized and honored.
   add_ocsp_test(
     "ocsp-stapling-none.example.com",
     SEC_ERROR_OCSP_UNKNOWN_CERT,
     [
@@ -195,17 +195,17 @@ function add_tests() {
 
   // The Good response retrieved from the previous fetch must have replaced
   // the Unknown response in the cache, resulting in the catched Good response
   // being returned and no fetch.
   add_ocsp_test(
     "ocsp-stapling-none.example.com",
     PRErrorCodeSuccess,
     [],
-    "Cached Good response -> a fetch should not have been" + " attempted"
+    "Cached Good response -> a fetch should not have been attempted"
   );
 
   // ---------------------------------------------------------------------------
 
   // Reset state
   add_test(function() {
     clearOCSPCache();
     run_next_test();
@@ -220,26 +220,26 @@ function add_tests() {
     "No stapled response -> a fetch should have been attempted"
   );
 
   // The error entry will prevent a fetch from happening for a while.
   add_ocsp_test(
     "ocsp-stapling-none.example.com",
     PRErrorCodeSuccess,
     [],
-    "Noted OCSP server failure -> a fetch should not have been" + " attempted"
+    "Noted OCSP server failure -> a fetch should not have been attempted"
   );
 
   // The error entry must not prevent a stapled OCSP response from being
   // honored.
   add_ocsp_test(
     "ocsp-stapling-revoked.example.com",
     SEC_ERROR_REVOKED_CERTIFICATE,
     [],
-    "Stapled Revoked response -> a fetch should not have been" + " attempted"
+    "Stapled Revoked response -> a fetch should not have been attempted"
   );
 
   // ---------------------------------------------------------------------------
 
   // Ensure OCSP responses from signers with SHA1 certificates are OK. This
   // is included in the OCSP caching tests since there were OCSP cache-related
   // regressions when sha-1 telemetry probes were added.
   add_test(function() {
--- a/security/manager/tools/genHPKPStaticPins.js
+++ b/security/manager/tools/genHPKPStaticPins.js
@@ -248,17 +248,17 @@ function downloadAndParseChromeCerts(fil
           certSKDToName[hash] = chromeName;
           state = PRE_NAME;
         } else if (line.startsWith(BEGIN_CERT)) {
           state = IN_CERT;
         } else if (line.startsWith(BEGIN_PUB_KEY)) {
           state = IN_PUB_KEY;
         } else {
           throw new Error(
-            "ERROR: couldn't parse Chrome certificate file " + "line: " + line
+            "ERROR: couldn't parse Chrome certificate file line: " + line
           );
         }
         break;
       case IN_CERT:
         if (line.startsWith(END_CERT)) {
           state = PRE_NAME;
           hash = getSKDFromPem(pemCert);
           pemCert = "";
--- a/security/manager/tools/genRootCAHashes.js
+++ b/security/manager/tools/genRootCAHashes.js
@@ -209,17 +209,17 @@ function insertTrustAnchorsFromDatabase(
 }
 
 //
 //  PRIMARY LOGIC
 //
 
 if (arguments.length != 1) {
   throw new Error(
-    "Usage: genRootCAHashes.js " + "<absolute path to current RootHashes.inc>"
+    "Usage: genRootCAHashes.js <absolute path to current RootHashes.inc>"
   );
 }
 
 var trustAnchorsFile = FileUtils.getFile("CurWorkD", [FILENAME_TRUST_ANCHORS]);
 // let rootHashesFile = FileUtils.getFile("CurWorkD", arguments[0]);
 var rootHashesFile = Cc["@mozilla.org/file/local;1"].createInstance(Ci.nsIFile);
 rootHashesFile.initWithPath(arguments[0]);