Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. - r=mrbkap
☠☠ backed out by 45f24b04f52b ☠ ☠
authorJeff Gilbert <jgilbert@mozilla.com>
Tue, 09 Aug 2016 17:15:18 -0700
changeset 309348 6cd485867a7df91ba8e2c363b5696d70e691daf8
parent 309347 522135225936a32c7b084ba7eea082ee025ea7d5
child 309349 ca7b62d9efb7f941f4cef2891017c8c1f73254f3
push id30561
push userkwierso@gmail.com
push dateMon, 15 Aug 2016 21:20:49 +0000
treeherdermozilla-central@91a319101587 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmrbkap
bugs1293845
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1293845 - Update webidl to be forward-compatible with final webgl2 webidl. - r=mrbkap MozReview-Commit-ID: DrUZODpNSml
dom/webidl/WebGL2RenderingContext.webidl
--- a/dom/webidl/WebGL2RenderingContext.webidl
+++ b/dom/webidl/WebGL2RenderingContext.webidl
@@ -313,38 +313,37 @@ interface WebGL2RenderingContext : WebGL
     const GLint64 TIMEOUT_IGNORED                              = -1;
 
     /* WebGL-specific enums */
     const GLenum MAX_CLIENT_WAIT_TIMEOUT_WEBGL                 = 0x9247;
 
     /* Buffer objects */
     void copyBufferSubData(GLenum readTarget, GLenum writeTarget, GLintptr readOffset,
                            GLintptr writeOffset, GLsizeiptr size);
-    void getBufferSubData(GLenum target, GLintptr offset, ArrayBuffer? returnedData);
-    void getBufferSubData(GLenum target, GLintptr offset, SharedArrayBuffer returnedData);
+    void getBufferSubData(GLenum target, GLintptr offset, ArrayBufferView dstData);
 
     [Throws] /* Throws on readback in a write-only context. */
     void readPixels(GLint x, GLint y, GLsizei width, GLsizei height, GLenum format,
                     GLenum type, GLintptr offset);
     /* Include our WebGL 1 function override(s) */
     [Throws]
     void readPixels(GLint x, GLint y, GLsizei width, GLsizei height, GLenum format,
-                    GLenum type, ArrayBufferView? pixels);
+                    GLenum type, ArrayBufferView pixels);
 
     /* Framebuffer objects */
     void blitFramebuffer(GLint srcX0, GLint srcY0, GLint srcX1, GLint srcY1, GLint dstX0, GLint dstY0,
                          GLint dstX1, GLint dstY1, GLbitfield mask, GLenum filter);
     void framebufferTextureLayer(GLenum target, GLenum attachment, WebGLTexture? texture, GLint level, GLint layer);
 
     [Throws]
     void invalidateFramebuffer(GLenum target, sequence<GLenum> attachments);
 
     [Throws]
-    void invalidateSubFramebuffer (GLenum target, sequence<GLenum> attachments,
-                                   GLint x, GLint y, GLsizei width, GLsizei height);
+    void invalidateSubFramebuffer(GLenum target, sequence<GLenum> attachments, GLint x,
+                                  GLint y, GLsizei width, GLsizei height);
 
     void readBuffer(GLenum src);
 
     /* Renderbuffer objects */
     [Throws]
     any getInternalformatParameter(GLenum target, GLenum internalformat, GLenum pname);
     void renderbufferStorageMultisample(GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height);
 
@@ -361,20 +360,20 @@ interface WebGL2RenderingContext : WebGL
                     GLsizei height, GLsizei depth, GLint border, GLenum format,
                     GLenum type, ArrayBufferView? pixels);
 
     //////
 
     [Throws] // Can't actually throw.
     void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLint zoffset, GLsizei width, GLsizei height, GLsizei depth,
-                       GLenum format, GLenum type, ArrayBufferView? pixels);
+                       GLenum format, GLenum type, ArrayBufferView pixels);
     [Throws] // Can't actually throw.
     void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
-                       GLint zoffset, GLenum format, GLenum type, ImageData? data);
+                       GLint zoffset, GLenum format, GLenum type, ImageData data);
     [Throws]
     void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLint zoffset, GLenum format, GLenum type, HTMLImageElement image);
     [Throws]
     void texSubImage3D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLint zoffset, GLenum format, GLenum type,
                        HTMLCanvasElement canvas);
     [Throws]
@@ -422,36 +421,36 @@ interface WebGL2RenderingContext : WebGL
 
     // Overloads must share [Throws].
     [Throws] // Can't throw.
     void texImage2D(GLenum target, GLint level, GLenum internalformat, GLsizei width,
                     GLsizei height, GLint border, GLenum format, GLenum type,
                     ArrayBufferView? pixels);
     [Throws] // Can't throw.
     void texImage2D(GLenum target, GLint level, GLenum internalformat, GLenum format,
-                    GLenum type, ImageData? pixels);
+                    GLenum type, ImageData pixels);
     [Throws] // May throw DOMException
     void texImage2D(GLenum target, GLint level, GLenum internalformat, GLenum format,
                     GLenum type, HTMLImageElement image);
     [Throws] // May throw DOMException
     void texImage2D(GLenum target, GLint level, GLenum internalformat, GLenum format,
                     GLenum type, HTMLCanvasElement canvas);
     [Throws] // May throw DOMException
     void texImage2D(GLenum target, GLint level, GLenum internalformat, GLenum format,
                     GLenum type, HTMLVideoElement video);
 
     //////
 
     [Throws] // Can't throw.
     void texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLsizei width, GLsizei height, GLenum format, GLenum type,
-                       ArrayBufferView? pixels);
+                       ArrayBufferView pixels);
     [Throws] // Can't throw.
     void texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
-                       GLenum format, GLenum type, ImageData? pixels);
+                       GLenum format, GLenum type, ImageData pixels);
     [Throws]  // May throw DOMException
     void texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLenum format, GLenum type, HTMLImageElement image);
     [Throws] // May throw DOMException
     void texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,
                        GLenum format, GLenum type, HTMLCanvasElement canvas);
     [Throws] // May throw DOMException
     void texSubImage2D(GLenum target, GLint level, GLint xoffset, GLint yoffset,