Bug 1363885 - 2. Remove ViERenderer dependency on orientation listener; r=snorp
authorJim Chen <nchen@mozilla.com>
Thu, 25 May 2017 18:33:30 -0400
changeset 360736 6b91b33444eb0b779bc18da64bb1abc17b5314a6
parent 360735 de4a54a0212ca8e57a770aa1794c8383902c02b9
child 360737 35d857a41a7b6f269b6b2fa0c64e6f28168110e1
push id31894
push userryanvm@gmail.com
push dateFri, 26 May 2017 01:31:24 +0000
treeherdermozilla-central@862e534ade6d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp
bugs1363885
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1363885 - 2. Remove ViERenderer dependency on orientation listener; r=snorp ViERenderer is not used anywhere but has a couple calls to the obsolete GeckoAppShell orientation listener. The entire ViERenderer.java file is getting removed in the upcoming WebRTC update, so we should just go ahead and remove those lines. MozReview-Commit-ID: AwG7dBg5MV8
media/webrtc/trunk/webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViERenderer.java
--- a/media/webrtc/trunk/webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViERenderer.java
+++ b/media/webrtc/trunk/webrtc/modules/video_render/android/java/src/org/webrtc/videoengine/ViERenderer.java
@@ -33,31 +33,29 @@ public class ViERenderer {
     // ViECapture::AllocateCaptureDevice
     // LinearLayout.addview
     // ViECapture::StartCapture
     public static void CreateLocalRenderer() {
         ThreadUtils.getUiHandler().post(new Runnable() {
             @Override
             public void run() {
                 try {
-                    GeckoAppShell.getGeckoInterface().enableOrientationListener();
                 } catch (Exception e) {
                     Log.e(TAG, "enableOrientationListener exception: "
                           + e.getLocalizedMessage());
                 }
             }
         });
     }
 
     public static void DestroyLocalRenderer() {
         ThreadUtils.getUiHandler().post(new Runnable() {
             @Override
             public void run() {
                 try {
-                    GeckoAppShell.getGeckoInterface().disableOrientationListener();
                 } catch (Exception e) {
                     Log.e(TAG,
                           "disableOrientationListener exception: " +
                           e.getLocalizedMessage());
                 }
             }
         });
     }