Bug 832957 - Fix for dom bug 835175 in selection overlay. r=mbrubeck
authorJim Mathies <jmathies@mozilla.com>
Wed, 27 Feb 2013 10:27:48 -0600
changeset 123181 6b2a53188ca12f57115e2a3535547ff09d62d609
parent 123180 33dd2de9984f47821ff359ad1a9159d33409cd35
child 123182 0ad8a9bf306a2912605d7a4af3d65f4c9f95bc77
push id24373
push userryanvm@gmail.com
push dateThu, 28 Feb 2013 01:36:21 +0000
treeherdermozilla-central@8cb9d6981978 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmbrubeck
bugs832957, 835175
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 832957 - Fix for dom bug 835175 in selection overlay. r=mbrubeck
browser/metro/base/content/bindings/browser.xml
browser/metro/base/content/browser.xul
--- a/browser/metro/base/content/bindings/browser.xml
+++ b/browser/metro/base/content/bindings/browser.xml
@@ -492,16 +492,17 @@
           toString: function() {
             return "[View Local]";
           }
         })
         ]]>
       </field>
 
       <!-- Change client coordinates in device pixels to page-relative ones in CSS px. -->
+      <!-- (Does not take into account sub frame scroll) -->
       <method name="transformClientToBrowser">
         <parameter name="clientX"/>
         <parameter name="clientY"/>
         <body>
           <![CDATA[
             let bcr = this.getBoundingClientRect();
             let scroll = this.getRootView().getPosition();
             return { x: (clientX + scroll.x - bcr.left) / this.scale,
--- a/browser/metro/base/content/browser.xul
+++ b/browser/metro/base/content/browser.xul
@@ -676,17 +676,18 @@
       <image id="alerts-image"/>
       <vbox flex="1">
         <label id="alerts-title" value=""/>
         <description id="alerts-text" flex="1"/>
       </vbox>
     </hbox>
 
     <!-- Selection overlay - this should be below any content that can have selectable text -->
-    <box class="selection-overlay-hidden" id="selection-overlay"/>
+    <!-- onclick addresses dom bug 835175, str in bug 832957 -->
+    <box onclick="false" class="selection-overlay-hidden" id="selection-overlay"/>
   </stack>
 
   <svg:svg height="0">
     <svg:clipPath id="forward-button-clip-path" clipPathUnits="objectBoundingBox">
       <svg:path d="M 0,0 C 0.15,0.12 0.25,0.3 0.25,0.5 0.25,0.7 0.15,0.88 0,1 L 1,1 1,0 0,0 z"/>
     </svg:clipPath>
     <svg:clipPath id="back-button-clip-path" clipPathUnits="userSpaceOnUse">
       <svg:path d="m -1,-5 0,4.03 C 3.6,1.8 18,21.4 0,40 l 0,27 10000,0 0,-55 L 0,-5 z" />