Bug 1425203 - Update gdb support code to use new signature of wasm SIGSEGV/SIGBUS handler. r=bbouvier
authorDragan Mladjenovic <dragan.mladjenovic@rt-rk.com>
Mon, 18 Dec 2017 20:07:10 -0500
changeset 396825 69ecf79f0dcb00e595d982a5122c8656ae20c4c6
parent 396824 eda5e8f3d9b29ab4bf758202c90c94569bce5601
child 396826 3b3bd97ecf4547e8454d06ec51d0f01966d8b68d
push id33112
push userdluca@mozilla.com
push dateTue, 19 Dec 2017 10:10:10 +0000
treeherdermozilla-central@c9ce08c45635 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbbouvier
bugs1425203
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1425203 - Update gdb support code to use new signature of wasm SIGSEGV/SIGBUS handler. r=bbouvier
js/src/gdb/mozilla/asmjs.py
--- a/js/src/gdb/mozilla/asmjs.py
+++ b/js/src/gdb/mozilla/asmjs.py
@@ -17,17 +17,17 @@ def on_stop(event):
         buf = sigaction_buffers.get(process)
         if buf is None:
             buf = gdb.parse_and_eval("(struct sigaction *) malloc(sizeof(struct sigaction))")
             sigaction_buffers[process] = buf
 
         # See if WasmFaultHandler is installed as the SIGSEGV signal action.
         sigaction_fn = gdb.parse_and_eval('__sigaction')
         sigaction_fn(SIGSEGV, 0, buf)
-        WasmFaultHandler = gdb.parse_and_eval("WasmFaultHandler<(Signal)0>")
+        WasmFaultHandler = gdb.parse_and_eval("WasmFaultHandler")
         if buf['__sigaction_handler']['sa_handler'] == WasmFaultHandler:
             # Advise the user that magic is happening.
             print("js/src/gdb/mozilla/asmjs.py: Allowing WasmFaultHandler to run.")
 
             # If WasmFaultHandler doesn't handle this segfault, it will unhook
             # itself and re-raise.
             gdb.execute("continue")