Bug 1523851 - Remove the AC_FUNC_MEMCMP test. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 30 Jan 2019 14:38:56 +0000
changeset 456219 697b9cab7789cb0b5701a636efbecbf24f211ad4
parent 456218 bf3ead324b247c2830a12d28705af5f837bf1e8d
child 456220 699954de14e37c54a20651b01351365c30c5f932
push id35475
push userrmaries@mozilla.com
push dateThu, 31 Jan 2019 16:55:18 +0000
treeherdermozilla-central@c936686484a1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1523851
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523851 - Remove the AC_FUNC_MEMCMP test. r=froydnj Autoconf 2.13 documentation says: "If the memcmp function is not available, or does not work on 8-bit data (like the one on SunOS 4.1.3), add `memcmp.o' to output variable LIBOBJS." The documentation of more recent versions of autoconf also mention NeXT x86 OpenStep, and say "This macro is obsolescent, as current systems have a working memcmp. New programs need not use this macro." We're also not using LIBOBJS, so, even if somehow some machine had the test detect something weird going on, the result of the test wouldn't have an effect on the build anyways. Apart from that, it's also one of the few tests that relies on actually running a compiled binary during configure, which requires some autoconf-specific definition of cross-compilation (where --target=i686 --host=x86_64 is not cross-compilation), and we're better off getting rid of such tests completely. Depends on D18054 Differential Revision: https://phabricator.services.mozilla.com/D18055
js/src/old-configure.in
old-configure.in
--- a/js/src/old-configure.in
+++ b/js/src/old-configure.in
@@ -995,17 +995,16 @@ then
 
 	esac
     LDFLAGS="${_PTHREAD_LDFLAGS} ${LDFLAGS}"
 fi
 
 
 dnl Checks for library functions.
 dnl ========================================================
-AC_FUNC_MEMCMP
 AC_CHECK_FUNCS([getc_unlocked _getc_nolock gmtime_r localtime_r pthread_getname_np pthread_get_name_np])
 
 dnl check for clock_gettime(), the CLOCK_MONOTONIC clock
 dnl avoid this on Darwin, since depending on your system config, we may think
 dnl it exists but it really doesn't
 case "$OS_TARGET" in
 Darwin)
   ;;
--- a/old-configure.in
+++ b/old-configure.in
@@ -1270,17 +1270,16 @@ then
     LDFLAGS="${_PTHREAD_LDFLAGS} ${LDFLAGS}"
     AC_SUBST(MOZ_USE_PTHREADS)
     MOZ_CHECK_HEADERS(pthread.h)
 fi
 
 
 dnl Checks for library functions.
 dnl ========================================================
-AC_FUNC_MEMCMP
 AC_CHECK_FUNCS(stat64 lstat64 truncate64 statvfs64 statvfs statfs64 statfs getpagesize gmtime_r localtime_r arc4random arc4random_buf mallinfo gettid lchown setpriority strerror syscall)
 
 dnl check for clock_gettime(), the CLOCK_MONOTONIC clock
 dnl avoid this on Darwin, since depending on your system config, we may think
 dnl it exists but it really doesn't
 case "$OS_TARGET" in
 Darwin)
   ;;