Bug 1603804. Move third_party/python/lldbutils to python/lldbutils. r=ahal
☠☠ backed out by ce2b3465d903 ☠ ☠
authorJonathan Watt <jwatt@jwatt.org>
Thu, 19 Dec 2019 16:37:46 +0000
changeset 507870 69687a23245e28d052a71c4eb1195423554bdafb
parent 507869 83d20f9e3bf3cbccd0cccc5e77779c61c6339060
child 507871 63d700057a9d1087c0d53989ac2d3ad541787fab
push id36932
push useraciure@mozilla.com
push dateThu, 19 Dec 2019 21:52:02 +0000
treeherdermozilla-central@8e1b11b00157 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs1603804, 1346025, 1605144, 1605145
milestone73.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1603804. Move third_party/python/lldbutils to python/lldbutils. r=ahal This undoes the mistaken move of this directory into third_party that happened as part of bug 1346025. The .flake8 changes are required because lldbutils used to be excluded from linting by virtue of being inside third_party, but would otherwise be subject to it after this move. Fixing the existing lint errors will happen in: - https://bugzilla.mozilla.org/show_bug.cgi?id=1605144 - https://bugzilla.mozilla.org/show_bug.cgi?id=1605145 Differential Revision: https://phabricator.services.mozilla.com/D57141
.flake8
.lldbinit
python/lldbutils/README.txt
python/lldbutils/lldbutils/__init__.py
python/lldbutils/lldbutils/content.py
python/lldbutils/lldbutils/general.py
python/lldbutils/lldbutils/gfx.py
python/lldbutils/lldbutils/layout.py
python/lldbutils/lldbutils/utils.py
third_party/python/lldbutils/README.txt
third_party/python/lldbutils/lldbutils/__init__.py
third_party/python/lldbutils/lldbutils/content.py
third_party/python/lldbutils/lldbutils/general.py
third_party/python/lldbutils/lldbutils/gfx.py
third_party/python/lldbutils/lldbutils/layout.py
third_party/python/lldbutils/lldbutils/utils.py
--- a/.flake8
+++ b/.flake8
@@ -19,16 +19,17 @@ exclude =
     layout/reftests/w3c-css,
     layout/style,
     media/libdav1d/generate_source.py,
     moz.configure,
     netwerk/dns/prepare_tlds.py,
     netwerk/protocol/http/make_incoming_tables.py,
     python/devtools/migrate-l10n/migrate/main.py,
     python/l10n/fluent_migrations,
+    python/lldbutils,
     python/mozbuild/dumbmake,
     security/manager/ssl/tests/unit,
     servo/components/style,
     testing/condprofile/condprof/android.py,
     testing/condprofile/condprof/creator.py,
     testing/condprofile/condprof/desktop.py,
     testing/condprofile/condprof/runner.py,
     testing/condprofile/condprof/scenarii/heavy.py,
--- a/.lldbinit
+++ b/.lldbinit
@@ -5,17 +5,17 @@
 # in the accompanying Python scripts, see third_party/python/lldbutils/README.txt.
 # -----------------------------------------------------------------------------
 
 # Import the module that defines complex Gecko debugging commands.  This assumes
 # you are either running lldb from the top level source directory, the objdir,
 # or the dist/bin directory.  (.lldbinit files in the objdir and dist/bin set
 # topsrcdir appropriately.)
 script topsrcdir = topsrcdir if "topsrcdir" in locals() else os.getcwd()
-script sys.path.append(os.path.join(topsrcdir, "third_party/python/lldbutils"))
+script sys.path.append(os.path.join(topsrcdir, "python/lldbutils"))
 script import lldbutils
 script lldbutils.init()
 
 # Mozilla's use of UNIFIED_SOURCES to include multiple source files into a
 # single compiled file breaks lldb breakpoint setting. This works around that.
 # See http://lldb.llvm.org/troubleshooting.html for more info.
 settings set target.inline-breakpoint-strategy always
 
rename from third_party/python/lldbutils/README.txt
rename to python/lldbutils/README.txt
rename from third_party/python/lldbutils/lldbutils/__init__.py
rename to python/lldbutils/lldbutils/__init__.py
rename from third_party/python/lldbutils/lldbutils/content.py
rename to python/lldbutils/lldbutils/content.py
rename from third_party/python/lldbutils/lldbutils/general.py
rename to python/lldbutils/lldbutils/general.py
rename from third_party/python/lldbutils/lldbutils/gfx.py
rename to python/lldbutils/lldbutils/gfx.py
rename from third_party/python/lldbutils/lldbutils/layout.py
rename to python/lldbutils/lldbutils/layout.py
rename from third_party/python/lldbutils/lldbutils/utils.py
rename to python/lldbutils/lldbutils/utils.py