Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Wed, 23 Aug 2017 09:33:18 -0400
changeset 381676 68d44e7679e27532cd41393c0a421b5ebd1b93d9
parent 381675 ee4e36ce2400b37005d03e00895cf7d19bc2136e
child 381677 79e75fbda533329db3b7eded9f83426e0f44531d
push id32535
push userkwierso@gmail.com
push dateTue, 19 Sep 2017 21:06:08 +0000
treeherdermozilla-central@c0d1f9eb2a40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1392787
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1392787 - Add a linter to prevent comment-disabling tests in manifestparser manifests, r=jmaher MozReview-Commit-ID: LG47ASBMA17
taskcluster/ci/source-test/mozlint.yml
tools/lint/test-disable.yml
--- a/taskcluster/ci/source-test/mozlint.yml
+++ b/taskcluster/ci/source-test/mozlint.yml
@@ -48,16 +48,17 @@ py-compat:
         docker-image: {in-tree: "lint"}
         max-run-time: 1800
     run:
         using: mach
         mach: lint -l py2 -l py3 -f treeherder
     when:
         files-changed:
             - '**/*.py'
+            - '**/.flake8'
             - 'python/mozlint/**'
             - 'tools/lint/**'
 
 py-flake8:
     description: flake8 run over the gecko codebase
     platform: lint/opt
     treeherder:
         symbol: f8
@@ -72,16 +73,36 @@ py-flake8:
         mach: lint -l flake8 -f treeherder
     when:
         files-changed:
             - '**/*.py'
             - '**/.flake8'
             - 'python/mozlint/**'
             - 'tools/lint/**'
 
+test-manifest:
+    description: lint test manifests
+    platform: lint/opt
+    treeherder:
+        symbol: tm
+        kind: test
+        tier: 1
+    worker-type: aws-provisioner-v1/gecko-t-linux-xlarge
+    worker:
+        docker-image: {in-tree: "lint"}
+        max-run-time: 1800
+    run:
+        using: mach
+        mach: lint -l test-disable -f treeherder
+    when:
+        files-changed:
+            - '**/*.ini'
+            - 'python/mozlint/**'
+            - 'tools/lint/**'
+
 wptlint-gecko:
     description: web-platform-tests linter
     platform: lint/opt
     treeherder:
         symbol: W
         kind: test
         tier: 1
     worker-type: aws-provisioner-v1/gecko-t-linux-xlarge
new file mode 100644
--- /dev/null
+++ b/tools/lint/test-disable.yml
@@ -0,0 +1,14 @@
+---
+no-comment-disable:
+    description: "Use 'disable=<reason>' to disable a test instead of a comment"
+    include:
+        - "**/*.ini"
+    exclude:
+        - "**/application.ini"
+        - "**/l10n.ini"
+        - testing/mozbase/manifestparser/tests
+        - testing/web-platform
+        - xpcom/tests/unit/data
+    extensions: ['ini']
+    type: regex
+    payload: ^[ \t]*(#|;)[ \t]*\[