Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh
authorMichael Comella <michael.l.comella@gmail.com>
Tue, 16 Jun 2015 19:29:28 -0700
changeset 249386 67b89eefbb5642cbb7f8bf610ef44d0864bf974b
parent 249385 43b338ccbaa972c660e97d186b5245fa1b5d5baa
child 249387 9213957d166dfb840ee60259bead690dcd2850cf
push id28924
push userryanvm@gmail.com
push dateWed, 17 Jun 2015 19:01:32 +0000
treeherdermozilla-central@a3f280b6f8d5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmhaigh
bugs1170884
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1170884 - Add explicit orientation to LinearLayouts. r=mhaigh android-lint recommends this as part of it's "Orientation" rule.
mobile/android/base/resources/layout/gecko_app.xml
mobile/android/base/resources/layout/menu_popup.xml
--- a/mobile/android/base/resources/layout/gecko_app.xml
+++ b/mobile/android/base/resources/layout/gecko_app.xml
@@ -58,17 +58,18 @@
             </FrameLayout>
 
             <LinearLayout android:id="@+id/doorhanger_overlay"
                           android:layout_width="match_parent"
                           android:layout_height="match_parent"
                           android:background="@color/dark_transparent_overlay"
                           android:visibility="gone"
                           android:alpha="0"
-                          android:layerType="hardware"/>
+                          android:layerType="hardware"
+                          android:orientation="horizontal" />
 
         </RelativeLayout>
 
         <org.mozilla.gecko.FindInPageBar android:id="@+id/find_in_page"
                                          android:layout_width="match_parent"
                                          android:layout_height="wrap_content"
                                          android:layout_alignParentBottom="true"
                                          style="@style/FindBar"
--- a/mobile/android/base/resources/layout/menu_popup.xml
+++ b/mobile/android/base/resources/layout/menu_popup.xml
@@ -4,13 +4,14 @@
    - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
               android:id="@+id/menu_panel"
               android:layout_width="@dimen/menu_popup_width"
               android:layout_height="wrap_content"
               android:layout_alignParentRight="true"
               android:minWidth="@dimen/menu_popup_width"
-              android:background="@drawable/menu_popup_bg">
+              android:background="@drawable/menu_popup_bg"
+              android:orientation="horizontal">
 
     <!-- MenuPanel will be added here dynamically -->
 
 </LinearLayout>