Bug 587248 - Part 16: Don't resize the groups if we explicitly request their size to remain constant while dragging; r=ian a=blocking-betaN+
authorEhsan Akhgari <ehsan@mozilla.com>
Thu, 11 Nov 2010 21:11:28 -0500
changeset 57465 674f2ed15cea35d849f5e72f33abd00cb89175a9
parent 57464 3e275c148e5dbe5ccebc3a9c9a4f06b7f3401c03
child 57466 2213446a018b4e943363a0e5180a1b477b98adfa
push id16934
push usereakhgari@mozilla.com
push dateSat, 13 Nov 2010 22:50:22 +0000
treeherdermozilla-central@674f2ed15cea [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersian, blocking-betaN
bugs587248
milestone2.0b8pre
first release with
nightly linux32
674f2ed15cea / 4.0b8pre / 20101114015932 / files
nightly linux64
674f2ed15cea / 4.0b8pre / 20101114030636 / files
nightly mac
674f2ed15cea / 4.0b8pre / 20101114030749 / files
nightly win32
674f2ed15cea / 4.0b8pre / 20101114042436 / files
nightly win64
674f2ed15cea / 4.0b8pre / 20101114062057 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 587248 - Part 16: Don't resize the groups if we explicitly request their size to remain constant while dragging; r=ian a=blocking-betaN+
browser/base/content/tabview/drag.js
--- a/browser/base/content/tabview/drag.js
+++ b/browser/base/content/tabview/drag.js
@@ -200,17 +200,17 @@ Drag.prototype = {
     var swb = this.safeWindowBounds;
     var update = false;
     var updateX = false;
     var updateY = false;
     var snappedTrenches = {};
 
     var snapRadius = (Keys.meta ? 0 : Trenches.defaultRadius);
     if (rect.left < swb.left + snapRadius ) {
-      if (stationaryCorner.indexOf('right') > -1)
+      if (stationaryCorner.indexOf('right') > -1 && !assumeConstantSize)
         rect.width = rect.right - swb.left;
       rect.left = swb.left;
       update = true;
       updateX = true;
       snappedTrenches.left = 'edge';
     }
 
     if (rect.right > swb.right - snapRadius) {
@@ -223,17 +223,17 @@ Drag.prototype = {
       } else if (!updateX || !Trenches.preferLeft) {
         rect.left = swb.right - rect.width;
         update = true;
       }
       snappedTrenches.right = 'edge';
       delete snappedTrenches.left;
     }
     if (rect.top < swb.top + snapRadius) {
-      if (stationaryCorner.indexOf('bottom') > -1)
+      if (stationaryCorner.indexOf('bottom') > -1 && !assumeConstantSize)
         rect.height = rect.bottom - swb.top;
       rect.top = swb.top;
       update = true;
       updateY = true;
       snappedTrenches.top = 'edge';
     }
     if (rect.bottom > swb.bottom - snapRadius) {
       if (updateY || !assumeConstantSize) {