Bug 1192901 - Avoid wrong accesskey for "Disable Addon" button by passing empty string, r=gijs
authorYFdyh000 <yfdyh000@gmail.com>
Mon, 10 Aug 2015 15:51:00 +0100
changeset 257797 66d1159b02a6bdf908b8818b2bbc800c258626b9
parent 257796 0bfda075f48486c4b6bdda5750cb307d59c1d3e9
child 257798 bd5b01dfe7d79cc45e0f41e5edcf08b91444e714
push id29228
push userryanvm@gmail.com
push dateFri, 14 Aug 2015 13:20:59 +0000
treeherdermozilla-central@beb9cc29efb9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgijs
bugs1192901
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1192901 - Avoid wrong accesskey for "Disable Addon" button by passing empty string, r=gijs
browser/components/nsBrowserGlue.js
--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -692,16 +692,17 @@ BrowserGlue.prototype = {
       let notificationId = 'addon-slow:' + addonId;
       let notification = notificationBox.getNotificationWithValue(notificationId);
       if(notification) {
         notification.label = message;
       } else {
         let buttons = [
           {
             label: win.gNavigatorBundle.getFormattedString("addonwatch.disable.label", [addon.name]),
+            accessKey: "", // workaround for bug 1192901
             callback: function() {
               addon.userDisabled = true;
               if (addon.pendingOperations != addon.PENDING_NONE) {
                 let restartMessage = win.gNavigatorBundle.getFormattedString("addonwatch.restart.message", [addon.name, brandShortName]);
                 let restartButton = [
                   {
                     label: win.gNavigatorBundle.getFormattedString("addonwatch.restart.label", [brandShortName]),
                     accessKey: win.gNavigatorBundle.getString("addonwatch.restart.accesskey"),