Revert d39bed41e215, because pty doesn't do the right thing when the process exits, creating a race condition
authorJesse Ruderman <jruderman@gmail.com>
Tue, 08 Jun 2010 20:55:43 -0700
changeset 43365 6679e57b27e3ef625dde1b1138d3d8b227763cb9
parent 43364 5a96e6ff047dce4afd45af5d3afdfe74f99bcaee
child 43366 6c1ece4396420749451754ef3caf32d45c18003f
push id13671
push userjruderman@mozilla.com
push dateWed, 09 Jun 2010 04:06:32 +0000
treeherdermozilla-central@6c1ece439642 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9.3a5pre
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Revert d39bed41e215, because pty doesn't do the right thing when the process exits, creating a race condition
tools/rb/fix_macosx_stack.py
--- a/tools/rb/fix_macosx_stack.py
+++ b/tools/rb/fix_macosx_stack.py
@@ -141,26 +141,17 @@ def fixSymbols(line):
     if result is not None:
         # before allows preservation of balance trees
         # after allows preservation of counts
         (before, file, address, after) = result.groups()
         address = int(address, 16)
 
         if os.path.exists(file) and os.path.isfile(file):
             address += address_adjustment(file)
-            try:
-                info = addressToSymbol(file, address)
-                if info.startswith("atos cannot"):
-                    # This can happen due to bug 550335 or bug 558947.
-                    sys.stderr.write("fix_macosx_stack will not convert some stack-trace addresses because: " + info + "\n")
-                    return line
-            except IOError:
-                # IOError can be the result of attempting to continue to use an
-                # atos process that has exited (e.g. due to the error above)
-                return line
+            info = addressToSymbol(file, address)
 
             # atos output seems to have three forms:
             #   address
             #   address (in foo.dylib)
             #   symbol (in foo.dylib) (file:line)
             symresult = atos_sym_re.match(info)
             if symresult is not None:
                 # Print the first two forms as-is, and transform the third