author | Jeff Walden <jwalden@mit.edu> |
Tue, 26 Feb 2019 17:06:47 -0800 | |
changeset 461653 | 66478b6fc575c9787e973fdea86260c63570f192 |
parent 461652 | 18308efff1417fe5354611dda756ab88633cf895 |
child 461654 | 110995301abe314fe48fd360961a37e2534167ad |
push id | 35626 |
push user | csabou@mozilla.com |
push date | Thu, 28 Feb 2019 11:31:08 +0000 |
treeherder | mozilla-central@2ea0c1db7e60 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | jorendorff |
bugs | 1530879 |
milestone | 67.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/js/src/tests/jstests.list +++ b/js/src/tests/jstests.list @@ -1223,15 +1223,20 @@ skip script test262/language/expressions # test262 importer merges all includes in a per directory shell.js file, breaking this harness test case. skip script test262/harness/detachArrayBuffer.js #################################################### # Tests disabled due to invalid test expectations # #################################################### +# https://github.com/tc39/proposal-json-superset going to stage 4 invalidates +# these tests. https://github.com/tc39/test262/pull/2044 later removes them. +skip script test262/language/line-terminators/invalid-string-ls.js +skip script test262/language/line-terminators/invalid-string-ps.js + # https://github.com/tc39/test262/pull/1965 skip script test262/language/expressions/dynamic-import/indirect-resolution.js skip script test262/language/expressions/dynamic-import/namespace/default-property-not-set-own.js # https://github.com/tc39/test262/pull/2023 skip script test262/language/statements/try/early-catch-var.js skip script test262/language/eval-code/direct/var-env-lower-lex-catch-non-strict.js
--- a/js/src/tests/test262/GIT-INFO +++ b/js/src/tests/test262/GIT-INFO @@ -1,5 +1,8 @@ -commit 8175f6c05eef922c062e8f5bfae0faaef9404202 +commit 3468dad291251d4759ab6270d4fb8b75befa8d93 Author: Mike Pennisi <mike@mikepennisi.com> -Date: Tue Jan 1 13:57:23 2019 -0500 +Date: Tue Jan 1 12:03:27 2019 -0500 - Improve name of line terminator tests + Improve coverage for line terminators + + Previous commits restructured the tests for line terminators and made + coverage gaps more apparent. Introduce new files to improve coverage.
new file mode 100644 --- /dev/null +++ b/js/src/tests/test262/language/line-terminators/comment-multi-ps.js @@ -0,0 +1,29 @@ +// |reftest| error:Test262Error +// Copyright 2019 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +info: Multi line comment can contain PARAGRAPH SEPARATOR (U+2029) +esid: sec-line-terminators +es5id: 7.3_A5.1_T2 +description: Insert real PARAGRAPH SEPARATOR into multi line comment +negative: + phase: runtime + type: Test262Error +---*/ + +// Because this test concerns the interpretation of non-executable character +// sequences within ECMAScript source code, special care must be taken to +// ensure that executable code is evaluated as expected. +// +// Express the intended behavior by intentionally throwing an error; this +// guarantees that test runners will only consider the test "passing" if +// executable sequences are correctly interpreted as such. + +var x = 0; + +/* x = 1; */ + +if (x === 0) { + throw new Test262Error(); +}
new file mode 100644 --- /dev/null +++ b/js/src/tests/test262/language/line-terminators/invalid-regexp-cr.js @@ -0,0 +1,18 @@ +// |reftest| error:SyntaxError +// Copyright 2019 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-line-terminators +es5id: 7.3-7 +description: > + 7.3 - ES5 recognizes the character <CR> (\u000D) as terminating + regular expression literals +negative: + phase: parse + type: SyntaxError +---*/ + +$DONOTEVALUATE(); + +/ /
new file mode 100644 --- /dev/null +++ b/js/src/tests/test262/language/line-terminators/invalid-regexp-lf.js @@ -0,0 +1,19 @@ +// |reftest| error:SyntaxError +// Copyright 2019 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +esid: sec-line-terminators +es5id: 7.3-7 +description: > + 7.3 - ES5 recognizes the character <LF> (\u000A) as terminating + regular expression literals +negative: + phase: parse + type: SyntaxError +---*/ + +$DONOTEVALUATE(); + +/ +/
new file mode 100644 --- /dev/null +++ b/js/src/tests/test262/language/line-terminators/invalid-string-ls.js @@ -0,0 +1,17 @@ +// |reftest| error:SyntaxError +// Copyright 2019 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +info: LINE SEPARATOR (U+2028) within strings is not allowed +es5id: 7.3_A2.2_T1 +esid: sec-line-terminators +description: Insert LINE SEPARATOR (\u2028) into string +negative: + phase: parse + type: SyntaxError +---*/ + +$DONOTEVALUATE(); + +' '
new file mode 100644 --- /dev/null +++ b/js/src/tests/test262/language/line-terminators/invalid-string-ps.js @@ -0,0 +1,17 @@ +// |reftest| error:SyntaxError +// Copyright 2019 Mike Pennisi. All rights reserved. +// This code is governed by the BSD license found in the LICENSE file. + +/*--- +info: PARAGRAPH SEPARATOR (U+2029) within strings is not allowed +es5id: 7.3_A2.2_T1 +esid: sec-line-terminators +description: Insert PARAGRAPH SEPARATOR (\u2029) into string +negative: + phase: parse + type: SyntaxError +---*/ + +$DONOTEVALUATE(); + +' '