Bug 1457863 - 1. Update kotlin to 1.2.41; r=nalexander
authorJim Chen <nchen@mozilla.com>
Wed, 02 May 2018 13:49:57 -0400
changeset 416699 65c4d7d9eab2db87d540189aa15dc881052e468c
parent 416698 f497b6c97c47aef6ef014f4075cdd839a663e83f
child 416700 fd6be860e5427ee31108bc5d0bdb2e0444af5f85
push id33932
push userrgurzau@mozilla.com
push dateWed, 02 May 2018 21:03:54 +0000
treeherdermozilla-central@a0f7e5f1bea6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnalexander
bugs1457863
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1457863 - 1. Update kotlin to 1.2.41; r=nalexander Update the kotlin version used for GeckoView tests to 1.2.41. Also turn on "warnings-as-errors", which is a compiler option introduced in kotlin 1.2. MozReview-Commit-ID: 7cL2v4jFJ27
build.gradle
mobile/android/geckoview/build.gradle
--- a/build.gradle
+++ b/build.gradle
@@ -45,17 +45,17 @@ buildscript {
             }
         }
         // For in tree plugins.
         maven {
             url "file://${gradle.mozconfig.topsrcdir}/mobile/android/gradle/m2repo"
         }
     }
 
-    ext.kotlin_version = '1.1.51'
+    ext.kotlin_version = '1.2.41'
     ext.support_library_version = '23.4.0'
 
     if (gradle.mozconfig.substs.MOZ_ANDROID_GOOGLE_PLAY_SERVICES) {
         ext.google_play_services_version = '8.4.0'
     }
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.0.1'
--- a/mobile/android/geckoview/build.gradle
+++ b/mobile/android/geckoview/build.gradle
@@ -169,16 +169,20 @@ tasks.withType(org.jetbrains.kotlin.grad
             }
             def (_, type, file, line, column, message) = matches[0]
             type = (type == 'w') ? 'warning' : 'error'
             // Use logger.lifecycle, which does not go through stderr again.
             logger.lifecycle "$file:$line:$column: $type: $message"
         }
     } as StandardOutputListener
 
+    kotlinOptions {
+        allWarningsAsErrors = true
+    }
+
     doFirst {
         logging.addStandardErrorListener(listener)
     }
     doLast {
         logging.removeStandardErrorListener(listener)
     }
 }