Bug 841146: Remove unused member-variable 'compileContext_' from class ParallelArrayVisitor. r=nmatsakis
authorDaniel Holbert <dholbert@cs.stanford.edu>
Wed, 13 Feb 2013 16:27:13 -0800
changeset 121824 659e228ab14f77688cd067db2f7729715fe6e331
parent 121823 e5694309feed7c06c4a3372f8a6d9d9e592a1bf2
child 121825 cef766712c20ecb434c5d318363e8de02b790e11
push id24307
push useremorley@mozilla.com
push dateThu, 14 Feb 2013 10:47:46 +0000
treeherdermozilla-central@aceeea086ccb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnmatsakis
bugs841146
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 841146: Remove unused member-variable 'compileContext_' from class ParallelArrayVisitor. r=nmatsakis
js/src/ion/ParallelArrayAnalysis.cpp
--- a/js/src/ion/ParallelArrayAnalysis.cpp
+++ b/js/src/ion/ParallelArrayAnalysis.cpp
@@ -64,17 +64,16 @@ using parallel::SpewCompile;
         if (prop->racy())                                                     \
             return true;                                                      \
         return insertWriteGuard(prop, prop->obj());                           \
     }
 
 class ParallelArrayVisitor : public MInstructionVisitor
 {
     JSContext *cx_;
-    ParallelCompileContext &compileContext_;
     MIRGraph &graph_;
     bool unsafe_;
     MDefinition *parSlice_;
 
     bool insertWriteGuard(MInstruction *writeInstruction,
                           MDefinition *valueBeingWritten);
 
     bool replaceWithParNew(MInstruction *newInstruction,
@@ -92,20 +91,19 @@ class ParallelArrayVisitor : public MIns
         JS_ASSERT(!unsafe_);
         unsafe_ = true;
         return true;
     }
 
   public:
     AutoObjectVector callTargets;
 
-    ParallelArrayVisitor(JSContext *cx, ParallelCompileContext &compileContext,
+    ParallelArrayVisitor(JSContext *cx,
                          MIRGraph &graph)
       : cx_(cx),
-        compileContext_(compileContext),
         graph_(graph),
         unsafe_(false),
         parSlice_(NULL),
         callTargets(cx)
     { }
 
     void clearUnsafe() { unsafe_ = false; }
     bool unsafe() { return unsafe_; }
@@ -326,17 +324,17 @@ ParallelCompileContext::analyzeAndGrowWo
 {
     // Walk the basic blocks in a DFS.  When we encounter a block with an
     // unsafe instruction, then we know that this block will bailout when
     // executed.  Therefore, we replace the block.
     //
     // We don't need a worklist, though, because the graph is sorted
     // in RPO.  Therefore, we just use the marked flags to tell us
     // when we visited some predecessor of the current block.
-    ParallelArrayVisitor visitor(cx_, *this, graph);
+    ParallelArrayVisitor visitor(cx_, graph);
     graph.entryBlock()->mark();  // Note: in par. exec., we never enter from OSR.
     uint32_t marked = 0;
     for (ReversePostorderIterator block(graph.rpoBegin()); block != graph.rpoEnd(); block++) {
         if (mir->shouldCancel("ParallelArrayAnalysis"))
             return false;
 
         if (block->isMarked()) {
             // Iterate through and transform the instructions.  Stop