Bug 1539665 - Remove arrowScrollbox as 'this' parameter into Array.filter;r=dao
authorBrian Grinstead <bgrinstead@mozilla.com>
Fri, 29 Mar 2019 16:00:08 +0000
changeset 466784 657dd79f0363df00daeb7873429a19c1fbb8028c
parent 466783 2cbcf3ac7ca69ca7717c8a8232b293f75ef2ca8a
child 466785 f7f9e20d71b78bdbd94d73d9ab3225b212a2be37
push id35780
push useropoprus@mozilla.com
push dateFri, 29 Mar 2019 21:53:01 +0000
treeherdermozilla-central@414f37afbe07 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1539665
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1539665 - Remove arrowScrollbox as 'this' parameter into Array.filter;r=dao It's unused, since _canScrollToElement is overridden right below and doesn't use 'this'. Differential Revision: https://phabricator.services.mozilla.com/D25412
browser/base/content/tabbrowser.xml
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -175,17 +175,17 @@
             this.setAttribute("overflow", "true");
             this._positionPinnedTabs();
             this._handleTabSelect(true);
           });
 
           // Override scrollbox.xml method, since our scrollbox's children are
           // inherited from the scrollbox binding parent (this).
           arrowScrollbox._getScrollableElements = () => {
-            return Array.filter(this.children, arrowScrollbox._canScrollToElement, arrowScrollbox);
+            return Array.filter(this.children, arrowScrollbox._canScrollToElement);
           };
           arrowScrollbox._canScrollToElement = tab => {
             return !tab._pinnedUnscrollable && !tab.hidden;
           };
         ]]></body>
       </method>
 
       <method name="observe">