mozilla-central: changeset 71403:64b58e1da898dc8f3f91ffe16cb66f10ed5ba669

☠☠ backed out by ea1856ff64d1 ☠ ☠
author	Mounir Lamouri <mounir.lamouri@gmail.com>
	Mon, 20 Jun 2011 19:02:42 +0200
changeset 71403	64b58e1da898dc8f3f91ffe16cb66f10ed5ba669
parent 71402	e8f3a7dd12b8b7af173bd1a0a58cf4a3663671ae
child 71404	ed017393232149ea9ef15aaab8741390445639c8
push id	20539
push user	mlamouri@mozilla.com
push date	Tue, 21 Jun 2011 07:35:09 +0000
treeherder	mozilla-central@bf714fffdfdf [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	mstange
bugs	664925, 665571
milestone	7.0a1
first release with	nightly linux32 b7a93f1279b7 / 7.0a1 / 20110622030844 / files nightly linux64 b7a93f1279b7 / 7.0a1 / 20110622030844 / files nightly mac b7a93f1279b7 / 7.0a1 / 20110622030844 / files nightly win32 b7a93f1279b7 / 7.0a1 / 20110622030844 / files nightly win64 b7a93f1279b7 / 7.0a1 / 20110622030205 / files
last release without	nightly linux32 058a584ea7d3 / 7.0a1 / 20110620030833 / files nightly linux64 058a584ea7d3 / 7.0a1 / 20110620030833 / files nightly mac 058a584ea7d3 / 7.0a1 / 20110620030833 / files nightly win32 058a584ea7d3 / 7.0a1 / 20110620030833 / files nightly win64 058a584ea7d3 / 7.0a1 / 20110620030203 / files

new file mode 100644
--- /dev/null
+++ b/widget/reftests/664925.xhtml
@@ -0,0 +1,1 @@
+<html xmlns="http://www.w3.org/1999/xhtml"><div><td style="-moz-appearance: progressbar;"></td></div></html>

--- a/widget/reftests/reftest.list
+++ b/widget/reftests/reftest.list
@@ -1,2 +1,3 @@
 skip-if(!cocoaWidget) != 507947.html about:blank
 == progressbar-fallback-default-style.html progressbar-fallback-default-style-ref.html
+load 664925.xhtml

--- a/widget/src/cocoa/nsNativeThemeCocoa.mm
+++ b/widget/src/cocoa/nsNativeThemeCocoa.mm
@@ -1138,17 +1138,20 @@ nsNativeThemeCocoa::DrawFrame(CGContextR
 }
 
 static const CellRenderSettings progressSettings[2][2] = {
   // Vertical progress bar.
   {
     // Determined settings.
     {
       {
-        NSZeroSize, // mini
+        // TODO: for the moment, DrawCellWithSnapping doesn't handle NSZeroSize
+        // values in this array so we have to use negative values until
+        // bug 665571 is fixed.
+        NSMakeSize(-5, -5), // mini
         NSMakeSize(10, 0), // small
         NSMakeSize(16, 0)  // regular
       },
       {
         NSZeroSize, NSZeroSize, NSZeroSize
       },
       {
         { // Leopard
@@ -1156,17 +1159,20 @@ static const CellRenderSettings progress
           {1, 1, 1, 1},     // small
           {1, 1, 1, 1}      // regular
         }
       }
     },
     // There is no horizontal margin in regular undetermined size.
     {
       {
-        NSZeroSize, // mini
+        // TODO: for the moment, DrawCellWithSnapping doesn't handle NSZeroSize
+        // values in this array so we have to use negative values until
+        // bug 665571 is fixed.
+        NSMakeSize(-5, -5), // mini
         NSMakeSize(10, 0), // small
         NSMakeSize(16, 0)  // regular
       },
       {
         NSZeroSize, NSZeroSize, NSZeroSize
       },
       {
         { // Leopard

widget/reftests/664925.xhtml		file \| annotate \| diff \| comparison \| revisions
widget/reftests/reftest.list		file \| annotate \| diff \| comparison \| revisions
widget/src/cocoa/nsNativeThemeCocoa.mm		file \| annotate \| diff \| comparison \| revisions