Backed out changeset 9c8923903d73 (bug 1508279) because peculative fix submitted had no effect on the bug
authorAndreea Pavel <apavel@mozilla.com>
Sat, 19 Jan 2019 03:03:59 +0200
changeset 454502 64aa8ab3332b0f84707424779368b5ace23ec761
parent 454501 e29be447ca751eb0fd8b854631c3eee176dba32e
child 454503 cbac4cd15f5f66e4e9538e63e83709ce972aff00
push id35399
push usercsabou@mozilla.com
push dateSat, 19 Jan 2019 09:28:26 +0000
treeherdermozilla-central@64d167665c29 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1508279
milestone66.0a1
backs out9c8923903d734aabb5ff566b0da931cb7ee178aa
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 9c8923903d73 (bug 1508279) because peculative fix submitted had no effect on the bug
mobile/android/base/java/org/mozilla/gecko/notifications/NotificationReceiver.java
--- a/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationReceiver.java
+++ b/mobile/android/base/java/org/mozilla/gecko/notifications/NotificationReceiver.java
@@ -90,16 +90,21 @@ public class NotificationReceiver extend
         if (persistentIntent != null) {
             // Go through GeckoService for persistent notifications.
             GeckoServicesCreatorService.enqueueWork(context, persistentIntent);
         }
 
         if (NotificationClient.CLICK_ACTION.equals(action)) {
             GeckoAppShell.onNotificationClick(name, cookie);
 
+            if (persistentIntent != null) {
+                // Don't launch GeckoApp if it's a background persistent notification.
+                return;
+            }
+
             final Intent appIntent = new Intent(GeckoApp.ACTION_ALERT_CALLBACK);
             appIntent.setComponent(new ComponentName(
                     data.getAuthority(), data.getPath().substring(1))); // exclude leading slash.
             appIntent.setData(data);
             appIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
             context.startActivity(appIntent);
 
         } else if (NotificationClient.CLOSE_ACTION.equals(action)) {