Bug 1518703 - Remove R_386_PC32 check. r=froydnj,ted
authorMike Hommey <mh+mozilla@glandium.org>
Thu, 10 Jan 2019 00:07:53 +0000
changeset 453163 64255d8e90fe6b761a12f2406aaddb4080ff8e22
parent 453162 0871597bc67b53a65ad1b2ca71f9503594b280cd
child 453164 e818109ab4e11a0bf72c6213eef37ae9884d15ce
push id35346
push usershindli@mozilla.com
push dateThu, 10 Jan 2019 04:03:25 +0000
treeherdermozilla-central@a0cf88b1fe5b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj, ted
bugs1518703
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1518703 - Remove R_386_PC32 check. r=froydnj,ted The test is actually redundant with the TEXTREL check in check_binary.py (R_386_PC32 relocations will only happen as text relocations) Differential Revision: https://phabricator.services.mozilla.com/D16002
Makefile.in
--- a/Makefile.in
+++ b/Makefile.in
@@ -287,23 +287,16 @@ else
 maybe_clobber_profiledbuild:
 	$(RM) $(DIST)/bin/*.pgc
 	find $(DIST)/$(MOZ_APP_NAME) -name '*.pgc' -exec mv {} $(DIST)/bin \;
 endif # msvc
 endif # NO_PROFILE_GUIDED_OPTIMIZE
 
 .PHONY: maybe_clobber_profiledbuild
 
-# Look for R_386_PC32 relocations in shared libs, these
-# break x86_64 builds and SELinux users.
-ifeq ($(OS_TARGET)_$(TARGET_XPCOM_ABI),Linux_x86-gcc3)
-check::
-	@relcount=`find $(DIST)/bin -name '*.so' | xargs objdump -R | grep R_386_PC32 | wc -l` && if test $$relcount -gt 0; then echo 'FAILED: R_386_PC32 relocations detected in a shared library.  Did you use a system header without adding it to config/system-headers?'; exit 1; else echo 'PASSED'; fi
-endif
-
 ifdef JS_STANDALONE
 # Delegate js-specific rules to js
 check-%:
 	$(MAKE) -C js/src $@
 
 source-package install:
 	$(MAKE) -C js/src $@