Bug 1437780 - Wasm baseline, remove platform dependencies. r=bbouvier
authorLars T Hansen <lhansen@mozilla.com>
Tue, 13 Feb 2018 08:00:38 +0100
changeset 405325 63f61a9297cef37fe895e508acc7ac2d68900827
parent 405324 9f4a3fb51e9eeace806589512eb26bb923254113
child 405326 d2ffffb30b31aaaaf4d1d5623eb77894b0455806
push id33518
push usertoros@mozilla.com
push dateMon, 26 Feb 2018 22:20:13 +0000
treeherdermozilla-central@580d833df9c4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbbouvier
bugs1437780
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1437780 - Wasm baseline, remove platform dependencies. r=bbouvier
js/src/wasm/WasmBaselineCompile.cpp
--- a/js/src/wasm/WasmBaselineCompile.cpp
+++ b/js/src/wasm/WasmBaselineCompile.cpp
@@ -3745,40 +3745,42 @@ class BaseCompiler final : public BaseCo
         OutOfLineCode* ool = addOutOfLineCode(
             new (alloc_) OutOfLineTruncateCheckF32OrF64ToI64(AnyReg(src),
                                                              dest,
                                                              flags,
                                                              bytecodeOffset()));
         if (!ool)
             return false;
         bool isSaturating = flags & TRUNC_SATURATING;
-        if (flags & TRUNC_UNSIGNED)
+        if (flags & TRUNC_UNSIGNED) {
             masm.wasmTruncateFloat32ToUInt64(src, dest, isSaturating, ool->entry(),
                                              ool->rejoin(), temp);
-        else
+        } else {
             masm.wasmTruncateFloat32ToInt64(src, dest, isSaturating, ool->entry(),
                                             ool->rejoin(), temp);
+        }
         return true;
     }
 
     MOZ_MUST_USE bool truncateF64ToI64(RegF64 src, RegI64 dest, TruncFlags flags, RegF64 temp) {
         OutOfLineCode* ool = addOutOfLineCode(
             new (alloc_) OutOfLineTruncateCheckF32OrF64ToI64(AnyReg(src),
                                                              dest,
                                                              flags,
                                                              bytecodeOffset()));
         if (!ool)
             return false;
         bool isSaturating = flags & TRUNC_SATURATING;
-        if (flags & TRUNC_UNSIGNED)
+        if (flags & TRUNC_UNSIGNED) {
             masm.wasmTruncateDoubleToUInt64(src, dest, isSaturating, ool->entry(),
                                             ool->rejoin(), temp);
-        else
+        } else {
             masm.wasmTruncateDoubleToInt64(src, dest, isSaturating, ool->entry(),
                                            ool->rejoin(), temp);
+        }
         return true;
     }
 #endif // RABALDR_FLOAT_TO_I64_CALLOUT
 
 #ifndef RABALDR_I64_TO_FLOAT_CALLOUT
     RegI32 needConvertI64ToFloatTemp(ValType to, bool isUnsigned) {
         bool needs = false;
         if (to == ValType::F64) {