Bug 1567499 - Re-allow eval with system principal on Nightly while we investigate crashes. r=smaug, a=RyanVM
authorTom Ritter <tom@mozilla.com>
Fri, 19 Jul 2019 13:20:40 -0400
changeset 483475 63ef0618ec9a07c438701e0357ef0d37abea0dd8
parent 483474 eb7f4d56f54b3283fc15983ee859b5e62fcb9f3b
child 483517 23d4ebd5f8e70bb86f179556572b55655d6e066d
push id36320
push userryanvm@gmail.com
push dateFri, 19 Jul 2019 18:01:18 +0000
treeherdermozilla-central@63ef0618ec9a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug, RyanVM
bugs1567499
milestone70.0a1
first release with
nightly linux32
63ef0618ec9a / 70.0a1 / 20190719180118 / files
nightly linux64
63ef0618ec9a / 70.0a1 / 20190719180118 / files
nightly mac
63ef0618ec9a / 70.0a1 / 20190719180118 / files
nightly win32
63ef0618ec9a / 70.0a1 / 20190719180118 / files
nightly win64
63ef0618ec9a / 70.0a1 / 20190719180118 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1567499 - Re-allow eval with system principal on Nightly while we investigate crashes. r=smaug, a=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D38682
modules/libpref/init/StaticPrefList.yaml
modules/libpref/init/all.js
--- a/modules/libpref/init/StaticPrefList.yaml
+++ b/modules/libpref/init/StaticPrefList.yaml
@@ -5762,17 +5762,17 @@
 
 - name: security.csp.reporting.script-sample.max-length
   type: int32_t
   value: 40
   mirror: always
 
 - name: security.allow_eval_with_system_principal
   type: bool
-  value: false
+  value: true
   mirror: always
 
 # Whether strict file origin policy is in effect.
 - name: security.fileuri.strict_origin_policy
   type: RelaxedAtomicBool
   value: true
   mirror: always
 
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -2449,24 +2449,16 @@ pref("security.notification_enable_delay
 
 #if defined(DEBUG) && !defined(ANDROID)
 pref("csp.about_uris_without_csp", "blank,printpreview,srcdoc,addons,config,downloads,home,newtab,preferences,sync-log");
 // the following prefs are for testing purposes only.
 pref("csp.overrule_about_uris_without_csp_whitelist", false);
 pref("csp.skip_about_page_has_csp_assert", false);
 #endif
 
-#if !defined(ANDROID)
-#if defined(NIGHTLY_BUILD) || defined(DEBUG)
-// assertion flag will be set to false after fixing Bug 1473549
-pref("security.allow_eval_with_system_principal", false);
-pref("security.uris_using_eval_with_system_principal", "autocomplete.xml,redux.js,react-redux.js,content-task.js,lodash.js,jszip.js,sinon-7.2.7.js,ajv-4.1.1.js,jsol.js");
-#endif
-#endif
-
 #ifdef EARLY_BETA_OR_EARLIER
 // Disallow web documents loaded with the SystemPrincipal
 pref("security.disallow_non_local_systemprincipal_in_tests", false);
 #endif
 
 // Mixed content blocking
 pref("security.mixed_content.block_active_content", false);
 pref("security.mixed_content.block_display_content", false);