Bug 1466602 [wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly
authorMorten Stenshorne <mstensho@chromium.org>
Mon, 25 Jun 2018 21:53:14 +0000
changeset 424251 639f167c7b4d3d442e8a0fcb88acc8633593b0f2
parent 424250 5ffdb75443cc057d3d9c08f50e7101b170be56b9
child 424252 0d3432333a78b581a2108159c57de76f023ac212
push id34201
push usershindli@mozilla.com
push dateThu, 28 Jun 2018 21:54:04 +0000
treeherdermozilla-central@8f49b2a0e003 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1466602, 11330, 847807, 1084989, 564438
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1466602 [wpt PR 11330] - [LayoutNG] Need to know when establishing a new FC during min/max calculation., a=testonly Automatic update from web-platform-tests[LayoutNG] Need to know when establishing a new FC during min/max calculation. When we have to lay out an object to determine its min/max inline size, and the node establishes a new formatting context, we need to create a constraint space that reflects this. The block size of the float needs to be included in the block size of its container, because this block size will be the min/max preferred inline size of the container of that container, if the writing modes are orthogonal. Avoid some duplicate code for creating the constraint space builder. The second builder, the one that redoes layout with infinite available space now gets SetFloatsBfcOffset() called, which was previously missing, but that must have been an oversight. This fixes the recently introduced regression with fast/multicol/vertical-rl/column-rules.html and also another test. Wrote a new test that tests exactly what I wanted to fix as well. Bug: 847807 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I7b28a0ef8061fc3089deb488ad0a78b81776295d Reviewed-on: https://chromium-review.googlesource.com/1084989 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#564438} -- wpt-commits: aa5ec97282685cba4a2ae34165ddb5043c251e39 wpt-pr: 11330
testing/web-platform/meta/MANIFEST.json
testing/web-platform/tests/css/css-writing-modes/float-in-htb-in-vrl.html
--- a/testing/web-platform/meta/MANIFEST.json
+++ b/testing/web-platform/meta/MANIFEST.json
@@ -157344,16 +157344,28 @@
       [
        "/css/css-writing-modes/float-contiguous-vrl-012-ref.xht",
        "=="
       ]
      ],
      {}
     ]
    ],
+   "css/css-writing-modes/float-in-htb-in-vrl.html": [
+    [
+     "/css/css-writing-modes/float-in-htb-in-vrl.html",
+     [
+      [
+       "/css/reference/ref-filled-green-100px-square.xht",
+       "=="
+      ]
+     ],
+     {}
+    ]
+   ],
    "css/css-writing-modes/float-lft-orthog-htb-in-vlr-002.xht": [
     [
      "/css/css-writing-modes/float-lft-orthog-htb-in-vlr-002.xht",
      [
       [
        "/css/css-writing-modes/float-lft-orthog-htb-in-vlr-002-ref.xht",
        "=="
       ]
@@ -543305,16 +543317,20 @@
   "css/css-writing-modes/float-contiguous-vrl-012-ref.xht": [
    "6540152d30dfb4ad492077d21f66942ced026240",
    "support"
   ],
   "css/css-writing-modes/float-contiguous-vrl-012.xht": [
    "4cbcdb79cf6f1359855fd4c9668327bdbd15859b",
    "reftest"
   ],
+  "css/css-writing-modes/float-in-htb-in-vrl.html": [
+   "17eaf8be10afb7fc1b5c6f861624365875667711",
+   "reftest"
+  ],
   "css/css-writing-modes/float-lft-orthog-htb-in-vlr-002-ref.xht": [
    "3a6acd515d3631525965d274582b81f7df575a2d",
    "support"
   ],
   "css/css-writing-modes/float-lft-orthog-htb-in-vlr-002.xht": [
    "9f5089a9d34072d66d5be282abc2b4bda24717e0",
    "reftest"
   ],
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-writing-modes/float-in-htb-in-vrl.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<title>Fixed-size float in autosized htr in vrl</title>
+<link rel="author" title="Morten Stenshorne" href="mstensho@chromium.org">
+<link rel="help" href="https://www.w3.org/TR/css-sizing-3/#intrinsic" title="4. Intrinsic Size Determination">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="width:100px; height:100px; background:red;">
+  <div style="writing-mode:vertical-rl; background:green;">
+    <div style="writing-mode:horizontal-tb;">
+      <div style="float:left; width:100px; height:100px;"></div>
+    </div>
+  </div>
+</div>