Bug 1193546: Fix the way that webrtc requests warnings-as-errors. r=glandium f=jesup
authorDavid Major <dmajor@mozilla.com>
Thu, 13 Aug 2015 11:58:01 -0400
changeset 257607 63602bea8357dc37574bd5292182c2c419e5f740
parent 257606 fa170734154a12789670d9621be3483105b35558
child 257608 6ec8b34e2bc62bf6b43d56212a0c95c83141b9e2
push id29223
push userkwierso@gmail.com
push dateThu, 13 Aug 2015 22:18:08 +0000
treeherdermozilla-central@4b35236fc76e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersglandium
bugs1193546
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1193546: Fix the way that webrtc requests warnings-as-errors. r=glandium f=jesup
media/webrtc/moz.build
media/webrtc/signaling/signaling.gyp
--- a/media/webrtc/moz.build
+++ b/media/webrtc/moz.build
@@ -47,16 +47,17 @@ if CONFIG['MOZ_WEBRTC_SIGNALING']:
     GYP_DIRS += ['signaling']
     GYP_DIRS['signaling'].input = 'signaling/signaling.gyp'
     GYP_DIRS['signaling'].variables = gyp_vars.copy()
     GYP_DIRS['signaling'].variables.update(
         build_for_test=0,
         build_for_standalone=0
     )
     GYP_DIRS['signaling'].sandbox_vars['FINAL_LIBRARY'] = 'xul'
+    GYP_DIRS['signaling'].sandbox_vars['FAIL_ON_WARNINGS'] = True
     # Excluded for various symbol conflicts
     signaling_non_unified_sources = [
         'signaling/src/common/browser_logging/CSFLog.cpp',
         'signaling/src/jsep/JsepSessionImpl.cpp',
         'signaling/src/media-conduit/AudioConduit.cpp',
         'signaling/src/media-conduit/CodecStatistics.cpp',
         'signaling/src/media-conduit/MediaCodecVideoCodec.cpp',
         'signaling/src/media-conduit/VideoConduit.cpp',
@@ -95,16 +96,19 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'gonk
         GYP_DIRS['signalingtest'].input = 'signaling/signaling.gyp'
         GYP_DIRS['signalingtest'].variables = gyp_vars.copy()
         GYP_DIRS['signalingtest'].variables.update(
             build_for_test=1,
             moz_webrtc_mediacodec=0,
             build_for_standalone=0
         )
         GYP_DIRS['signalingtest'].non_unified_sources += signaling_non_unified_sources
+        GYP_DIRS['signalingtest'].sandbox_vars['FAIL_ON_WARNINGS'] = True
+
         GYP_DIRS += ['signalingstandalone']
         GYP_DIRS['signalingstandalone'].input = 'signaling/signaling.gyp'
         GYP_DIRS['signalingstandalone'].variables = gyp_vars.copy()
         GYP_DIRS['signalingstandalone'].variables.update(
             build_for_test=0,
             build_for_standalone=1
         )
         GYP_DIRS['signalingstandalone'].non_unified_sources += signaling_non_unified_sources
+        GYP_DIRS['signalingstandalone'].sandbox_vars['FAIL_ON_WARNINGS'] = True
--- a/media/webrtc/signaling/signaling.gyp
+++ b/media/webrtc/signaling/signaling.gyp
@@ -196,17 +196,16 @@
         'HAVE_UINT32_T=1',
         'HAVE_UINT64_T=1',
       ],
 
       'cflags_mozilla': [
         '$(NSPR_CFLAGS)',
         '$(NSS_CFLAGS)',
         '$(MOZ_PIXMAN_CFLAGS)',
-        '$(WARNINGS_AS_ERRORS)',
       ],
 
 
       #
       # Conditionals
       #
       'conditions': [
         # hack so I can change the include flow for SrtpFlow