Bug 1306642 - Backed out changeset 5bd8445b019f as final NSPR fix has landed. r=dmajor
authorMasatoshi Kimura <VYV03354@nifty.ne.jp>
Thu, 16 Aug 2018 19:06:42 +0900
changeset 431960 635d66906fe414e547522e7993a5e58662a77377
parent 431959 c94a29385a3acd3ece34e740b52c34db66956b70
child 431961 9b17b83509fdf49c722bb9956bd85730b46dc353
push id34456
push usertoros@mozilla.com
push dateThu, 16 Aug 2018 21:33:21 +0000
treeherdermozilla-central@72442cf86f54 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1306642
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1306642 - Backed out changeset 5bd8445b019f as final NSPR fix has landed. r=dmajor
mfbt/MemoryChecking.h
--- a/mfbt/MemoryChecking.h
+++ b/mfbt/MemoryChecking.h
@@ -41,22 +41,16 @@
 // In clang-cl based ASAN, we link against the memory poisoning functions
 // statically.
 #define MOZ_ASAN_VISIBILITY
 #else
 #define MOZ_ASAN_VISIBILITY MOZ_EXPORT
 #endif
 
 extern "C" {
-/* workaround for bug 1306642 */
-#if defined(_MSC_VER) && defined(__clang__)
-#pragma clang diagnostic warning "-Wdll-attribute-on-redeclaration"
-#pragma clang diagnostic warning "-Winconsistent-dllimport"
-#endif
-
 /* These definitions are usually provided through the
  * sanitizer/asan_interface.h header installed by ASan.
  */
 void MOZ_ASAN_VISIBILITY
 __asan_poison_memory_region(void const volatile *addr, size_t size);
 void MOZ_ASAN_VISIBILITY
 __asan_unpoison_memory_region(void const volatile *addr, size_t size);