Bug 1382680 Only add extended style WS_EX_COMPOSITED when using OMTC, r=bas,jimm
authorpeter chang <pchang@mozilla.com>
Wed, 16 Aug 2017 16:55:15 +0800
changeset 375876 62ab9018744dbf57f811ee26fac14542be5e02ee
parent 375875 575d130ab5f6566d43a0bed906127c0a1fa3d8b1
child 375877 4f8ac9b281dad727b4c7cc0a7bf6363f91e54aca
push id32366
push userarchaeopteryx@coole-files.de
push dateMon, 21 Aug 2017 11:40:50 +0000
treeherdermozilla-central@ecf9cc9bfca0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbas, jimm
bugs1382680
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1382680 Only add extended style WS_EX_COMPOSITED when using OMTC, r=bas,jimm MozReview-Commit-ID: 3jwGmJxE8zL
widget/windows/nsWindow.cpp
--- a/widget/windows/nsWindow.cpp
+++ b/widget/windows/nsWindow.cpp
@@ -788,17 +788,18 @@ nsWindow::Create(nsIWidget* aParent,
   DWORD extendedStyle = WindowExStyle();
 
   if (mWindowType == eWindowType_popup) {
     if (!aParent) {
       parent = nullptr;
     }
 
     if (!IsWin8OrLater() &&
-        HasBogusPopupsDropShadowOnMultiMonitor()) {
+        HasBogusPopupsDropShadowOnMultiMonitor() &&
+        ShouldUseOffMainThreadCompositing()) {
       extendedStyle |= WS_EX_COMPOSITED;
     }
 
     if (aInitData->mMouseTransparent) {
       // This flag makes the window transparent to mouse events
       mMouseTransparent = true;
       extendedStyle |= WS_EX_TRANSPARENT;
     }