Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r=ekr
authorRobert Bartlensky <rbartlensky@mozilla.com>
Thu, 19 Jul 2018 14:07:06 +0100
changeset 427484 6259a3d0d8a3caa42fd7b41faefdae3c183a63a1
parent 427483 ece31a9e0c0b4b97fd0a1248c0f722c591dd82e7
child 427485 8b31d456f8cb28f3aa7adefabcaa1d5cb340d59b
push id34306
push usercsabou@mozilla.com
push dateFri, 20 Jul 2018 21:41:18 +0000
treeherdermozilla-central@d6a5e8aea651 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersekr
bugs1476644
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476644: Fix DEAD_STORE error in media/webrtc/signaling/gtest/videoconduit_unittests.cpp. r=ekr MozReview-Commit-ID: 8QRXhxgqYXm
media/webrtc/signaling/gtest/videoconduit_unittests.cpp
--- a/media/webrtc/signaling/gtest/videoconduit_unittests.cpp
+++ b/media/webrtc/signaling/gtest/videoconduit_unittests.cpp
@@ -776,16 +776,17 @@ TEST_F(VideoConduitTest, TestConfigureSe
   encoding2.constraints.scaleDownBy = 2;
   encoding3.constraints.scaleDownBy = 4;
 
   VideoCodecConfig codecConfig(120, "VP8", constraints);
   codecConfig.mSimulcastEncodings.push_back(encoding);
   codecConfig.mSimulcastEncodings.push_back(encoding2);
   codecConfig.mSimulcastEncodings.push_back(encoding3);
   ec = mVideoConduit->ConfigureCodecMode(webrtc::VideoCodecMode::kScreensharing);
+  ASSERT_EQ(ec, kMediaConduitNoError);
   ec = mVideoConduit->ConfigureSendMediaCodec(&codecConfig);
   ASSERT_EQ(ec, kMediaConduitNoError);
   mVideoConduit->StartTransmitting();
   std::vector<webrtc::VideoStream> videoStreams;
   videoStreams = mCall->mEncoderConfig.video_stream_factory->CreateEncoderStreams(640, 480, mCall->mEncoderConfig);
   ASSERT_EQ(videoStreams.size(), 1U);
   mVideoConduit->StopTransmitting();
 }