Bug 803306. Calling a named creator should not define an expando. r=peterv
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 05 Nov 2012 11:58:03 -0500
changeset 112322 6184b17f8abd6c1166d3e1c629900a4483638308
parent 112321 b67a1dba5690052f4c4c0785732321c6a3c05fa9
child 112323 b74aba46826fbc60b742065aa1983d10e7be809f
push id23812
push useremorley@mozilla.com
push dateTue, 06 Nov 2012 14:01:34 +0000
treeherdermozilla-central@f4aeed115e54 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs803306
milestone19.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 803306. Calling a named creator should not define an expando. r=peterv
dom/bindings/Codegen.py
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -5266,16 +5266,17 @@ class CGDOMJSProxyHandler_defineProperty
                     "  FakeDependentString name;\n"
                     "  if (!ConvertJSValueToString(cx, nameVal, &nameVal,\n" +
                     "                              eStringify, eStringify, name)) {\n" +
                     "    return false;\n" +
                     "  }\n" +
                     "\n" +
                     "  %s* self = UnwrapProxy(proxy);\n" +
                     CGIndenter(CGProxyNamedSetter(self.descriptor)).define() + "\n" +
+                    "  return true;\n" +
                     "}\n") % (self.descriptor.nativeType)
         elif self.descriptor.operations['NamedGetter']:
             set += ("if (JSID_IS_STRING(id)) {\n" +
                     "  JS::Value nameVal = STRING_TO_JSVAL(JSID_TO_STRING(id));\n" +
                     "  FakeDependentString name;\n"
                     "  if (!ConvertJSValueToString(cx, nameVal, &nameVal,\n" +
                     "                              eStringify, eStringify, name)) {\n" +
                     "    return false;\n" +