Bug 1541818 - Remove atime check on mac; r=froydnj
authorMike Shal <mshal@mozilla.com>
Fri, 26 Apr 2019 13:47:33 +0000
changeset 471817 613c0da061aaac4eed66ed7c94ef0509c49f5ae6
parent 471816 3a10833865f1ba444cd6be44b0ef3f951cfd90e1
child 471818 3eb938b576a99000bff84b6ec314f938959e8e88
push id35935
push usershindli@mozilla.com
push dateTue, 30 Apr 2019 03:46:04 +0000
treeherdermozilla-central@f3c2a7206699 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1541818
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1541818 - Remove atime check on mac; r=froydnj The noatime option doesn't appear to have a significant impact on no-op build times, even though the build system does a significant number of file reads. Since macs have atime enabled by default, we should just disable this check rather than give developers unhelpful error messages. Differential Revision: https://phabricator.services.mozilla.com/D28906
python/mozbuild/mozbuild/doctor.py
--- a/python/mozbuild/mozbuild/doctor.py
+++ b/python/mozbuild/mozbuild/doctor.py
@@ -220,17 +220,17 @@ class Doctor(object):
                         else:
                             status = 'BAD, NOT FIXED'
                 else:
                     status = 'BAD, FIXABLE'
                     desc = 'lastaccess enabled'
                     fixable = True
             results.append({'status': status, 'desc': desc, 'fixable': fixable,
                             'denied': denied})
-        elif self.platform in ['darwin', 'freebsd', 'linux', 'openbsd']:
+        elif self.platform in ['freebsd', 'linux', 'openbsd']:
             common_mountpoint = self.srcdir_mount == self.objdir_mount
             for (purpose, path, mount) in self.path_mounts:
                 results.append(self.check_mount_lastaccess(mount))
                 if common_mountpoint:
                     break
         else:
             results.append({'status': 'SKIPPED'})
         return results