Bug 1073081 - Fix -Wattribute warnings by disabling them. r=ehsan,ted
authorBotond Ballo <botond@mozilla.com>
Mon, 24 Nov 2014 19:43:19 -0500
changeset 219628 60b12cab3b04d66ffb4a2690b39d994821e0169a
parent 219627 3506bbdc98bb797e38c3c5352c93df28805ab053
child 219629 9930760dfebc066e63224d0964e54a187ddebb7c
push id27967
push userryanvm@gmail.com
push dateMon, 15 Dec 2014 18:52:54 +0000
treeherdermozilla-central@5d6e0d038f95 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan, ted
bugs1073081
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1073081 - Fix -Wattribute warnings by disabling them. r=ehsan,ted
dom/camera/moz.build
dom/media/encoder/moz.build
dom/media/fmp4/gonk/moz.build
dom/media/moz.build
netwerk/protocol/rtsp/moz.build
widget/gonk/nativewindow/moz.build
--- a/dom/camera/moz.build
+++ b/dom/camera/moz.build
@@ -45,9 +45,15 @@ else:
 FAIL_ON_WARNINGS = True
 
 LOCAL_INCLUDES += [
     '../base',
 ]
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
+
 FINAL_LIBRARY = 'xul'
--- a/dom/media/encoder/moz.build
+++ b/dom/media/encoder/moz.build
@@ -45,8 +45,14 @@ CXXFLAGS += [
     '-I%s/%s' % (CONFIG['ANDROID_SOURCE'], d) for d in [
         'frameworks/native/opengl/include',
         'frameworks/native/include',
         'frameworks/av/include/media',
     ]
 ]
 
 include('/ipc/chromium/chromium-config.mozbuild')
+
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
--- a/dom/media/fmp4/gonk/moz.build
+++ b/dom/media/fmp4/gonk/moz.build
@@ -17,16 +17,22 @@ UNIFIED_SOURCES += [
     'GonkVideoDecoderManager.cpp',
 ]
 LOCAL_INCLUDES += [
     '/dom/media/omx/',
     '/dom/media/omx/mediaresourcemanager',
 ]
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
+
 FINAL_LIBRARY = 'xul'
 
 FAIL_ON_WARNINGS = True
 
 CXXFLAGS += [
     '-I%s/%s' % (CONFIG['ANDROID_SOURCE'], d) for d in [
         'frameworks/native/opengl/include',]
 ]
--- a/dom/media/moz.build
+++ b/dom/media/moz.build
@@ -268,9 +268,15 @@ if CONFIG['MOZ_OMX_DECODER']:
 if CONFIG['ANDROID_VERSION'] > '15':
     DEFINES['MOZ_OMX_WEBM_DECODER'] = True
 
 CFLAGS += CONFIG['GSTREAMER_CFLAGS']
 CXXFLAGS += CONFIG['GSTREAMER_CFLAGS']
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
+
 FINAL_LIBRARY = 'xul'
--- a/netwerk/protocol/rtsp/moz.build
+++ b/netwerk/protocol/rtsp/moz.build
@@ -43,16 +43,22 @@ SOURCES += [
 ]
 
 FAIL_ON_WARNINGS = True
 
 MSVC_ENABLE_PGO = True
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
+
 FINAL_LIBRARY = 'xul'
 
 DEFINES['IMPL_NS_NET'] = True
 DEFINES['FORCE_PR_LOG'] = True
 
 LOCAL_INCLUDES += [
     '../../base/src',
     '/dom/base',
--- a/widget/gonk/nativewindow/moz.build
+++ b/widget/gonk/nativewindow/moz.build
@@ -68,11 +68,17 @@ if CONFIG['MOZ_B2G_CAMERA'] or CONFIG['M
         SOURCES += [
             'FakeSurfaceComposer.cpp',
         ]
 
 FAIL_ON_WARNINGS = True
 
 include('/ipc/chromium/chromium-config.mozbuild')
 
+# Suppress some GCC warnings being treated as errors:
+#  - about attributes on forward declarations for types that are already
+#    defined, which complains about an important MOZ_EXPORT for android::AString
+if CONFIG['GNU_CC']:
+  CXXFLAGS += ['-Wno-error=attributes']
+
 FINAL_LIBRARY = 'xul'
 
 DISABLE_STL_WRAPPING = True