Bug 905369 - Use cached favicons on the start page [r=jimm]
authorMatt Brubeck <mbrubeck@mozilla.com>
Mon, 16 Dec 2013 09:22:24 -0800
changeset 160645 607c4a6ec53758d4ce8878d0b56b9095a711e8e2
parent 160644 f147cfedcc1fdabaaa66bead3e007f14f04b7e56
child 160646 b0a0fca79056d10d6029689b9df6e7c1d03807b0
push id25843
push userryanvm@gmail.com
push dateMon, 16 Dec 2013 21:54:22 +0000
treeherdermozilla-central@fcb3b07e7154 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm
bugs905369
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 905369 - Use cached favicons on the start page [r=jimm]
browser/metro/modules/View.jsm
--- a/browser/metro/modules/View.jsm
+++ b/browser/metro/modules/View.jsm
@@ -80,20 +80,20 @@ View.prototype = {
       if (aItem.refresh) {
         aItem.refresh();
       }
       return;
     }
     if ("string" == typeof aIconUri) {
       aIconUri = makeURI(aIconUri);
     }
-    aItem.iconSrc = aIconUri.spec;
     let faviconURL = (PlacesUtils.favicons.getFaviconLinkForIcon(aIconUri)).spec;
+    aItem.iconSrc = faviconURL;
+
     let xpFaviconURI = makeURI(faviconURL.replace("moz-anno:favicon:",""));
-
     Task.spawn(function() {
       let colorInfo = yield ColorUtils.getForegroundAndBackgroundIconColors(xpFaviconURI);
       if (!(colorInfo && colorInfo.background && colorInfo.foreground)) {
         return;
       }
       let { background, foreground } = colorInfo;
       aItem.style.color = foreground; //color text
       aItem.setAttribute("customColor", background);