Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz
☠☠ backed out by 4c4c08d01af4 ☠ ☠
authorDaosheng Mu <daoshengmu@gmail.com>
Tue, 21 May 2019 21:54:22 +0000
changeset 476121 607b23dcc62a132f9ee349901f6faadb66f71299
parent 476120 b8169dcf06315058ea9f3429e02408c9978b60a5
child 476122 4c4c08d01af4428b8dc2aa8d2066a81bb7e44ab8
push id36086
push usershindli@mozilla.com
push dateThu, 30 May 2019 03:47:55 +0000
treeherdermozilla-central@73c98da145a7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaklotz
bugs1523351
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D31114
dom/gamepad/android/AndroidGamepad.cpp
dom/gamepad/cocoa/CocoaGamepad.cpp
dom/gamepad/linux/LinuxGamepad.cpp
--- a/dom/gamepad/android/AndroidGamepad.cpp
+++ b/dom/gamepad/android/AndroidGamepad.cpp
@@ -74,10 +74,15 @@ void StartGamepadMonitoring() {
       java::GeckoAppShell::GetApplicationContext());
 }
 
 void StopGamepadMonitoring() {
   java::AndroidGamepadManager::Stop(
       java::GeckoAppShell::GetApplicationContext());
 }
 
+void SetGamepadLightIndicatorColor(uint32_t aControllerIdx, uint32_t aLightColorIndex,
+    uint8_t aRed, uint8_t aGreen, uint8_t aBlue) {
+  NS_WARNING("Android doesn't support gamepad light indicator.");
+}
+
 }  // namespace dom
 }  // namespace mozilla
--- a/dom/gamepad/cocoa/CocoaGamepad.cpp
+++ b/dom/gamepad/cocoa/CocoaGamepad.cpp
@@ -594,10 +594,16 @@ void StopGamepadMonitoring() {
   if (!gService) {
     return;
   }
 
   // Calling Shutdown() will delete gService as well
   gService->Shutdown();
 }
 
+void SetGamepadLightIndicatorColor(uint32_t aControllerIdx, uint32_t aLightColorIndex,
+    uint8_t aRed, uint8_t aGreen, uint8_t aBlue) {
+  // TODO: Bug 1523353.
+  NS_WARNING("Mac OS doesn't support gamepad light indicator.");
+}
+
 }  // namespace dom
 }  // namespace mozilla
--- a/dom/gamepad/linux/LinuxGamepad.cpp
+++ b/dom/gamepad/linux/LinuxGamepad.cpp
@@ -338,10 +338,16 @@ void StopGamepadMonitoring() {
   if (!gService) {
     return;
   }
   gService->Shutdown();
   delete gService;
   gService = nullptr;
 }
 
+void SetGamepadLightIndicatorColor(uint32_t aControllerIdx, uint32_t aLightColorIndex,
+    uint8_t aRed, uint8_t aGreen, uint8_t aBlue) {
+  // TODO: Bug 1523355.
+  NS_WARNING("Linux doesn't support gamepad light indicator.");
+}
+
 }  // namespace dom
 }  // namespace mozilla