Bug 1067664, part 2 - Stop ignoring tab process leaks. r=jmaher
☠☠ backed out by 8bc6dfe614be ☠ ☠
authorAndrew McCreight <continuation@gmail.com>
Fri, 26 Sep 2014 10:34:09 -0700
changeset 207545 605f59a806fd4e3cc5352cfc8634da0790dc385c
parent 207544 2d5b7ea96b706cb8ce68969eccaaac14756bd0d0
child 207546 35e71ffcf8e1ee097bb4dea75452e0eafe789704
push id27562
push usercbook@mozilla.com
push dateMon, 29 Sep 2014 13:45:04 +0000
treeherdermozilla-central@f57209ddc739 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher
bugs1067664
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1067664, part 2 - Stop ignoring tab process leaks. r=jmaher
build/automationutils.py
--- a/build/automationutils.py
+++ b/build/automationutils.py
@@ -281,24 +281,19 @@ def processSingleLeakFile(leakLogFileNam
     return
 
   if totalBytesLeaked == 0:
     log.info("TEST-PASS | leakcheck | %s no leaks detected!" % processString)
     return
 
   # totalBytesLeaked was seen and is non-zero.
   if totalBytesLeaked > leakThreshold:
-    if processType == "tab":
-      # For now, ignore tab process leaks. See bug 1051230.
-      log.info("WARNING | leakcheck | ignoring leaks in tab process")
-      prefix = "WARNING"
-    else:
-      logAsWarning = True
-      # Fail the run if we're over the threshold (which defaults to 0)
-      prefix = "TEST-UNEXPECTED-FAIL"
+    logAsWarning = True
+    # Fail the run if we're over the threshold (which defaults to 0)
+    prefix = "TEST-UNEXPECTED-FAIL"
   else:
     prefix = "WARNING"
   # Create a comma delimited string of the first N leaked objects found,
   # to aid with bug summary matching in TBPL. Note: The order of the objects
   # had no significance (they're sorted alphabetically).
   maxSummaryObjects = 5
   leakedObjectSummary = ', '.join(leakedObjectNames[:maxSummaryObjects])
   if len(leakedObjectNames) > maxSummaryObjects: