Bug 1585702 - [mozprocess] Temporarily disable 'env' default on Windows with Python 3, r=gbrown
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Thu, 03 Oct 2019 13:17:34 +0000
changeset 496168 6050b9e662edf1099201136cb1044bdc3cad3ade
parent 496167 4ba57765a7674e46842d2b6aa0bb07fae742522f
child 496169 b995dbfa4d87ea871205e4f41f8eca8460d2042f
push id36646
push usernerli@mozilla.com
push dateThu, 03 Oct 2019 21:48:01 +0000
treeherdermozilla-central@2e1bfb7458de [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgbrown
bugs1585702
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1585702 - [mozprocess] Temporarily disable 'env' default on Windows with Python 3, r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D47974
testing/mozbase/mozprocess/mozprocess/processhandler.py
--- a/testing/mozbase/mozprocess/mozprocess/processhandler.py
+++ b/testing/mozbase/mozprocess/mozprocess/processhandler.py
@@ -716,17 +716,19 @@ falling back to not using job objects fo
         self.args = args
         self.cwd = cwd
         self.didTimeout = False
         self.didOutputTimeout = False
         self._ignore_children = ignore_children
         self.keywordargs = kwargs
         self.read_buffer = ''
 
-        if env is None:
+        # XXX Bug 1585702 - Setting env is broken on Windows + Python 3. In the
+        # meantime let's at least make sure we don't set it in the default case.
+        if env is None and not (six.PY3 and isWin):
             env = os.environ.copy()
         self.env = env
 
         # handlers
         def to_callable_list(arg):
             if callable(arg):
                 arg = [arg]
             return CallableList(arg)